Issue 263333003: chrome.bluetoothLowEnergy: Implement writeCharacteristicValue.

Issue 263333003: chrome.bluetoothLowEnergy: Implement writeCharacteristicValue. (Closed)

Created:
6 years, 7 months ago by armansito

Modified:
6 years, 7 months ago

Reviewers:
keybuk, rpaquay

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome.bluetoothLowEnergy: Implement writeCharacteristicValue. This CL implements the writeCharacteristicValue function of the bluetoothLowEnergy API. BUG=265663 TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269509

Patch Set 1 #

Total comments: 2

Patch Set 2 : FU git cl format #

Patch Set 3 : Rebased #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -4 lines)			Patch
M	chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.h	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc	View	1 2	2 chunks	+48 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc	View	1 2	3 chunks	+56 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc	View	1 2	1 chunk	+22 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/runtest.js	View		1 chunk	+58 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

keybuk

lgtm https://codereview.chromium.org/263333003/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc File chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc (right): https://codereview.chromium.org/263333003/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc#newcode490 chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc:490: EXPECT_CALL(*mock_adapter_, GetDevice(_)).Times(3).WillRepeatedly( nit: break across multiple lines

6 years, 7 months ago (2014-05-06 16:44:19 UTC) #2

armansito

https://codereview.chromium.org/263333003/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc File chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc (right): https://codereview.chromium.org/263333003/diff/1/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc#newcode490 chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc:490: EXPECT_CALL(*mock_adapter_, GetDevice(_)).Times(3).WillRepeatedly( On 2014/05/06 16:44:19, keybuk wrote: > nit: ...

6 years, 7 months ago (2014-05-06 19:26:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/263333003/30001

6 years, 7 months ago (2014-05-09 02:01:41 UTC) #5

Message was sent while issue was closed.

Change committed as 269509

Expand Messages | Collapse Messages