Converts mash to use Shell

ash/mus/window_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_MUS_WINDOW_MANAGER_H_
 #define ASH_MUS_WINDOW_MANAGER_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <set>
 
 #include "ash/root_window_controller.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
-#include "base/observer_list.h"
 #include "services/ui/common/types.h"
 #include "services/ui/public/interfaces/display/display_controller.mojom.h"
 #include "services/ui/public/interfaces/window_manager.mojom.h"
 #include "ui/aura/mus/window_manager_delegate.h"
 #include "ui/aura/mus/window_tree_client_delegate.h"
 
-namespace aura {
-namespace client {
-class ActivationClient;
-}
-}
-
 namespace base {
 class SequencedWorkerPool;
 }
 
 namespace display {
 class Display;
 }
 
 namespace service_manager {
 class Connector;
 }
 
 namespace views {
 class PointerWatcherEventRouter;
 }
 
 namespace wm {
-class FocusController;
 class WMState;
 }
 
 namespace ash {
 
-class EventClientImpl;
-class ScreenPositionController;
 class ScreenMus;
+class SystemTrayDelegate;
 
 namespace mus {
 
 class AcceleratorHandler;
 class RootWindowController;
 class ShadowController;
-class WindowManagerObserver;
-class WmShellMus;
 class WmLookupMus;
 class WmTestHelper;
 
 // WindowManager serves as the WindowManagerDelegate and
 // WindowTreeClientDelegate for mash. WindowManager creates (and owns)
 // a RootWindowController per Display. WindowManager takes ownership of
 // the WindowTreeClient.
 class WindowManager : public aura::WindowManagerDelegate,
                       public aura::WindowTreeClientDelegate {
  public:
   explicit WindowManager(service_manager::Connector* connector);
   ~WindowManager() override;
 
   void Init(std::unique_ptr<aura::WindowTreeClient> window_tree_client,
             const scoped_refptr<base::SequencedWorkerPool>& blocking_pool);
 
-  WmShellMus* shell() { return shell_.get(); }
+  // Called during shutdown to delete all the RootWindowControllers.
+  void DeleteAllRootWindowControllers();
 
   ScreenMus* screen() { return screen_.get(); }
 
   aura::WindowTreeClient* window_tree_client() {
     return window_tree_client_.get();
   }
 
   aura::WindowManagerClient* window_manager_client() {
     return window_manager_client_;
   }
 
-  ::wm::FocusController* focus_controller() { return focus_controller_.get(); }
-
-  aura::client::ActivationClient* activation_client();
-
   service_manager::Connector* connector() { return connector_; }
 
   aura::PropertyConverter* property_converter() {
     return property_converter_.get();
   }
 
   // Creates a new top level window.
   aura::Window* NewTopLevelWindow(
       ui::mojom::WindowType window_type,
       std::map<std::string, std::vector<uint8_t>>* properties);
 
   std::set<RootWindowController*> GetRootWindowControllers();
 
   // Returns the next accelerator namespace id by value in |id|. Returns true
   // if there is another slot available, false if all slots are taken up.
   bool GetNextAcceleratorNamespaceId(uint16_t* id);
   void AddAcceleratorHandler(uint16_t id_namespace,
                              AcceleratorHandler* handler);
   void RemoveAcceleratorHandler(uint16_t id_namespace);
 
-  void AddObserver(WindowManagerObserver* observer);
-  void RemoveObserver(WindowManagerObserver* observer);
-
   // Returns the DisplayController interface if available. Will be null if no
   // service_manager::Connector was available, for example in some tests.
   display::mojom::DisplayController* GetDisplayController();
 
+  // Called during creation of the shell to create a RootWindowController.
+  // See comment in CreateRootWindowController() for details.
+  void CreatePrimaryRootWindowController(
+      std::unique_ptr<aura::WindowTreeHostMus> window_tree_host);
+
  private:
   friend class WmTestHelper;
 
   using RootWindowControllers = std::set<std::unique_ptr<RootWindowController>>;
 
-  RootWindowController* CreateRootWindowController(
+  // Called once the first Display has been obtained.
+  void CreateShell(
+      std::unique_ptr<aura::WindowTreeHostMus> primary_window_tree_host);
+
+  void CreateRootWindowController(
       std::unique_ptr<aura::WindowTreeHostMus> window_tree_host,
       const display::Display& display,
       ash::RootWindowController::RootWindowType root_window_type);
 
   // Deletes the specified RootWindowController. Called when a display is
-  // removed.
-  void DestroyRootWindowController(
-      RootWindowController* root_window_controller);
+  // removed. |in_shutdown| is true if called from Shutdown().
+  void DestroyRootWindowController(RootWindowController* root_window_controller,
+                                   bool in_shutdown);
 
   void Shutdown();
 
   RootWindowController* GetPrimaryRootWindowController();
 
   // Returns the RootWindowController where new top levels are created.
   // |properties| is the properties supplied during window creation.
   RootWindowController* GetRootWindowControllerForNewTopLevelWindow(
       std::map<std::string, std::vector<uint8_t>>* properties);
 
@@ skipping 34 matching lines @@
   void OnWmSetClientArea(
       aura::Window* window,
       const gfx::Insets& insets,
       const std::vector<gfx::Rect>& additional_client_areas) override;
   bool IsWindowActive(aura::Window* window) override;
   void OnWmDeactivateWindow(aura::Window* window) override;
 
   service_manager::Connector* connector_;
   display::mojom::DisplayControllerPtr display_controller_;
 
-  std::unique_ptr<::wm::FocusController> focus_controller_;
   std::unique_ptr<::wm::WMState> wm_state_;
   std::unique_ptr<aura::PropertyConverter> property_converter_;
 
   std::unique_ptr<aura::WindowTreeClient> window_tree_client_;
 
   aura::WindowManagerClient* window_manager_client_ = nullptr;
 
   std::unique_ptr<views::PointerWatcherEventRouter>
       pointer_watcher_event_router_;
 
   std::unique_ptr<ShadowController> shadow_controller_;
 
   RootWindowControllers root_window_controllers_;
 
-  base::ObserverList<WindowManagerObserver> observers_;
-
   std::unique_ptr<ScreenMus> screen_;
 
-  std::unique_ptr<WmShellMus> shell_;
+  bool created_shell_ = false;
 
   std::unique_ptr<WmLookupMus> lookup_;
 
   std::map<uint16_t, AcceleratorHandler*> accelerator_handlers_;
   uint16_t next_accelerator_namespace_id_ = 0u;
 
-  std::unique_ptr<EventClientImpl> event_client_;
+  scoped_refptr<base::SequencedWorkerPool> blocking_pool_;
 
-  std::unique_ptr<ScreenPositionController> screen_position_controller_;
+  // If non-null this is used as the return value from
+  // ShellDelegateMus::CreateSystemTrayDelegate(). This is only set in tests.
+  //
+  // TODO(jamescook): Pass a TestShellDelegate into WindowManager and use it to
+  // create the various test delegates rather than a mem

[James Cook, 2017/01/18 01:00:24]

mem?

[sky, 2017/01/18 04:00:07]

D'OH! 'member'. Updated.

+  std::unique_ptr<SystemTrayDelegate> system_tray_delegate_;

[James Cook, 2017/01/18 01:00:24]

system_tray_delegate_for_testing_? Then you could delete part of the comment.

[sky, 2017/01/18 04:00:07]

I renamed, but left the comment.

 
   DISALLOW_COPY_AND_ASSIGN(WindowManager);
 };
 
 }  // namespace mus
 }  // namespace ash
 
 #endif  // ASH_MUS_WINDOW_MANAGER_H_