Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2450)

Unified Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 2633253002: Split content script injections into multiple tasks (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebLocalFrame.h
diff --git a/third_party/WebKit/public/web/WebLocalFrame.h b/third_party/WebKit/public/web/WebLocalFrame.h
index 7f51aa1d49449953e6a18a00f4001a19ff8fb31b..e35c275a008bea305a9070a19ebc032ec9ffc3db 100644
--- a/third_party/WebKit/public/web/WebLocalFrame.h
+++ b/third_party/WebKit/public/web/WebLocalFrame.h
@@ -249,6 +249,15 @@ class WebLocalFrame : public WebFrame {
v8::Local<v8::Value> argv[],
WebScriptExecutionCallback*) = 0;
+ enum ScriptExecutionType {
+ // Execute script synchronously if possible.
haraken 2017/03/02 03:54:33 What do you mean by "if possible"?
Kunihiko Sakamoto 2017/03/06 09:11:06 Since requestExecute* functions use SuspendableScr
+ Synchronous,
+ // Execute script asynchronously.
+ Asynchronous,
+ // Execute script asynchronously, blocking the window.onload event.
+ AsyncBlockingOnload
haraken 2017/03/02 03:54:32 AsynchronousBlockingOnload
Kunihiko Sakamoto 2017/03/06 09:11:06 Done.
+ };
+
// worldID must be > 0 (as 0 represents the main world).
// worldID must be < EmbedderWorldIdLimit, high number used internally.
virtual void requestExecuteScriptInIsolatedWorld(
@@ -256,6 +265,7 @@ class WebLocalFrame : public WebFrame {
const WebScriptSource* sourceIn,
unsigned numSources,
bool userGesture,
+ ScriptExecutionType,
WebScriptExecutionCallback*) = 0;
// Associates an isolated world with human-readable name which is useful for

Powered by Google App Engine
This is Rietveld 408576698