chrome/test/data/extensions/platform_apps/web_view/content_script_whitelisted/main.js - Issue 2633253002: Split content script injections into multiple tasks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/content_script_whitelisted/main.js

Issue 2633253002: Split content script injections into multiple tasks (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.js ('K') | « chrome/test/data/extensions/api_test/content_scripts/about_blank_iframes/test.js ('k') | content/public/renderer/content_renderer_client.h » ('j') | extensions/renderer/script_injection.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/web_view/content_script_whitelisted/main.js

diff --git a/chrome/test/data/extensions/platform_apps/web_view/content_script_whitelisted/main.js b/chrome/test/data/extensions/platform_apps/web_view/content_script_whitelisted/main.js

index 8003fbebdee7e785a6dfac52151bebed3740d3d4..f8749bc783c1c66fc349d066ae9bba62773af85f 100644

--- a/chrome/test/data/extensions/platform_apps/web_view/content_script_whitelisted/main.js

+++ b/chrome/test/data/extensions/platform_apps/web_view/content_script_whitelisted/main.js

@@ -3,7 +3,7 @@

// found in the LICENSE file.

// This test makes sure webview properly loads and content script is run.

-onload = function() {

+document.addEventListener("DOMContentLoaded", function() {

Devlin 2017/03/02 02:33:17 nit: prefer single quotes but also, why this chang

Kunihiko Sakamoto 2017/03/06 09:11:05 This test failed when content script is injected b

var contentScriptRan = false;

var webviewLoaded = false;

@@ -42,4 +42,4 @@ onload = function() {

webview.setAttribute(

'src', 'data:text/html,<html><body>tear down test</body></html>');

document.body.appendChild(webview);

-};

+});