Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2011)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2633253002: Split content script injections into multiple tasks (Closed)
Patch Set: Inject document_idle scripts before window.onload Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index ffdc481f3ee6135e66de2696a191828d616921eb..5a04e09162bf8ea0ad27cba84936b9f9d79dc2a2 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1980,8 +1980,8 @@ void RenderFrameImpl::OnJavaScriptExecuteRequestInIsolatedWorld(
WebScriptSource script = WebScriptSource(WebString::fromUTF16(jscript));
JavaScriptIsolatedWorldRequest* request = new JavaScriptIsolatedWorldRequest(
id, notify_result, routing_id_, weak_factory_.GetWeakPtr());
- frame_->requestExecuteScriptInIsolatedWorld(world_id, &script, 1, false,
- request);
+ frame_->requestExecuteScriptInIsolatedWorld(
+ world_id, &script, 1, false, WebLocalFrame::Synchronous, request);
}
RenderFrameImpl::JavaScriptIsolatedWorldRequest::JavaScriptIsolatedWorldRequest(
@@ -3861,6 +3861,15 @@ void RenderFrameImpl::runScriptsAtDocumentReady(blink::WebLocalFrame* frame,
// Do not use |this| or |frame| here without checking |weak_self|.
}
+void RenderFrameImpl::runScriptsAtDocumentIdle(blink::WebLocalFrame* frame) {
+ DCHECK_EQ(frame_, frame);
+ base::WeakPtr<RenderFrameImpl> weak_self = weak_factory_.GetWeakPtr();
+ if (!weak_self.get())
+ return;
+
+ GetContentClient()->renderer()->RunScriptsAtDocumentIdle(this);
Devlin 2017/02/21 18:56:26 Probably worth adding a comment that |frame| and |
Kunihiko Sakamoto 2017/02/23 09:49:01 Done.
+}
+
void RenderFrameImpl::didHandleOnloadEvents(blink::WebLocalFrame* frame) {
DCHECK_EQ(frame_, frame);
if (!frame->parent()) {

Powered by Google App Engine
This is Rietveld 408576698