content/renderer/render_frame_impl.cc - Issue 2633253002: Split content script injections into multiple tasks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2633253002: Split content script injections into multiple tasks (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 7143f42028328f2e61076e4f23530e7bbe81be77..3a44865232f0b83914aff088f1fbfb8e2766e83b 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -1976,8 +1976,8 @@ void RenderFrameImpl::OnJavaScriptExecuteRequestInIsolatedWorld(

WebScriptSource script = WebScriptSource(WebString::fromUTF16(jscript));

JavaScriptIsolatedWorldRequest* request = new JavaScriptIsolatedWorldRequest(

id, notify_result, routing_id_, weak_factory_.GetWeakPtr());

- frame_->requestExecuteScriptInIsolatedWorld(world_id, &script, 1, false,

- request);

+ frame_->requestExecuteScriptInIsolatedWorld(

+ world_id, &script, 1, false, WebLocalFrame::Synchronous, request);

}

RenderFrameImpl::JavaScriptIsolatedWorldRequest::JavaScriptIsolatedWorldRequest(