Split content script injections into multiple tasks

third_party/WebKit/public/web/WebFrameClient.h

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 379 matching lines @@
 
   // The frame's document finished loading.
   // This method may not execute JavaScript code.
   virtual void didFinishDocumentLoad(WebLocalFrame*) {}
 
   // Like |didFinishDocumentLoad|, except this method may run JavaScript
   // code (and possibly invalidate the frame).
   virtual void runScriptsAtDocumentReady(WebLocalFrame*, bool documentIsEmpty) {
   }
 
+  // The frame's window.onload event is about to fire. This method may delay

[haraken, 2017/03/02 03:54:32]

Shall we drop the part of "The frame's window.onload event is about to fire"?
runScriptsAtDocumentIdle may run enough before window.onload, right?

[Kunihiko Sakamoto, 2017/03/06 09:11:06]

document_idle scripts may run enough before window.ounload, but not through this
function. Injection is triggered by runScriptsAtDocumentIdle, or a delayed task
posted by ScriptInjectionManager::RFOHelper::DidFinishDocumentLoad(). This
function is called only just before onload.

So this is a bit different from runScriptsAtDocument{Start,End}. Should we
emphasize that by renaming this, e.g. runScriptsAtDocumentIdleIfNeeded?

+  // window.onload by incrementing LoadEventDelayCount.
+  virtual void runScriptsAtDocumentIdle(WebLocalFrame*) {}
+
   // The 'load' event was dispatched.
   virtual void didHandleOnloadEvents(WebLocalFrame*) {}
 
   // The frame's document or one of its subresources failed to load. The
   // WebHistoryCommitType is the commit type that would have been used had the
   // load succeeded.
   virtual void didFailLoad(WebLocalFrame*,
                            const WebURLError&,
                            WebHistoryCommitType) {}
 
@@ skipping 344 matching lines @@
   // Overwrites the given URL to use an HTML5 embed if possible.
   // An empty URL is returned if the URL is not overriden.
   virtual WebURL overrideFlashEmbedWithHTML(const WebURL& url) {
     return WebURL();
   }
 };
 
 }  // namespace blink
 
 #endif