Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: content/browser/renderer_host/input/synthetic_pointer_driver.cc

Issue 2633233002: Add the pointer type of pen to the synthetic WebMousEvent (Closed)
Patch Set: pen type Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/synthetic_pointer_driver.cc
diff --git a/content/browser/renderer_host/input/synthetic_pointer_driver.cc b/content/browser/renderer_host/input/synthetic_pointer_driver.cc
index c59d86b6313e21f4f8d6d078614b3d084692743d..110bcfb70e9f151f77bf9f641e5c0393bc02b301 100644
--- a/content/browser/renderer_host/input/synthetic_pointer_driver.cc
+++ b/content/browser/renderer_host/input/synthetic_pointer_driver.cc
@@ -16,14 +16,17 @@ SyntheticPointerDriver::~SyntheticPointerDriver() {}
// static
std::unique_ptr<SyntheticPointerDriver> SyntheticPointerDriver::Create(
SyntheticGestureParams::GestureSourceType gesture_source_type) {
- if (gesture_source_type == SyntheticGestureParams::TOUCH_INPUT) {
- return base::MakeUnique<SyntheticTouchDriver>();
- } else if (gesture_source_type == SyntheticGestureParams::MOUSE_INPUT) {
- return base::MakeUnique<SyntheticMouseDriver>();
- } else {
- NOTREACHED() << "Invalid gesture source type";
- return std::unique_ptr<SyntheticPointerDriver>();
+ switch (gesture_source_type) {
+ case SyntheticGestureParams::TOUCH_INPUT:
+ return base::MakeUnique<SyntheticTouchDriver>();
+ case SyntheticGestureParams::MOUSE_INPUT:
+ case SyntheticGestureParams::PEN_INPUT:
+ return base::MakeUnique<SyntheticMouseDriver>(gesture_source_type);
tdresser 2017/01/25 15:22:46 This feels a bit clumsy - can we make it so there'
lanwei 2017/01/26 02:55:41 Done.
+ case SyntheticGestureParams::DEFAULT_INPUT:
+ return std::unique_ptr<SyntheticPointerDriver>();
}
+ NOTREACHED();
+ return std::unique_ptr<SyntheticPointerDriver>();
}
// static

Powered by Google App Engine
This is Rietveld 408576698