Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 263323004: HTMLTableRowElement.insertCell()'s argument default value should be -1 (Closed)

Created:
6 years, 7 months ago by Inactive
Modified:
6 years, 7 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

HTMLTableRowElement.insertCell()'s argument default value should be -1 HTMLTableRowElement.insertCell()'s argument default value should be -1, not 0, as per the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/tabular-data.html#the-tr-element The new behavior matches the one of Firefox 29 and IE11. R=arv@chromium.org, eseidel@chromium.org BUG=369803 TEST=fast/dom/HTMLTableRowElement/insertCell-default-argument.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173422

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
A LayoutTests/fast/dom/HTMLTableRowElement/insertCell-default-argument.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/HTMLTableRowElement/insertCell-default-argument-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 1 chunk +6 lines, -0 lines 2 comments Download
M Source/core/html/HTMLTableRowElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Inactive
6 years, 7 months ago (2014-05-06 00:15:00 UTC) #1
Inactive
Corresponding WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=132615
6 years, 7 months ago (2014-05-06 17:40:04 UTC) #2
arv (Not doing code reviews)
https://codereview.chromium.org/263323004/diff/1/Source/core/html/HTMLTableRowElement.cpp File Source/core/html/HTMLTableRowElement.cpp (right): https://codereview.chromium.org/263323004/diff/1/Source/core/html/HTMLTableRowElement.cpp#newcode143 Source/core/html/HTMLTableRowElement.cpp:143: n = firstChild(); This should be firstElementChild as well.
6 years, 7 months ago (2014-05-06 18:19:50 UTC) #3
Inactive
https://codereview.chromium.org/263323004/diff/1/Source/core/html/HTMLTableRowElement.cpp File Source/core/html/HTMLTableRowElement.cpp (right): https://codereview.chromium.org/263323004/diff/1/Source/core/html/HTMLTableRowElement.cpp#newcode143 Source/core/html/HTMLTableRowElement.cpp:143: n = firstChild(); On 2014/05/06 18:19:50, arv wrote: > ...
6 years, 7 months ago (2014-05-06 18:21:38 UTC) #4
arv (Not doing code reviews)
LGTM I second patch seems like the right thing to do.
6 years, 7 months ago (2014-05-06 18:33:14 UTC) #5
Inactive
On 2014/05/06 18:33:14, arv wrote: > LGTM > > I second patch seems like the ...
6 years, 7 months ago (2014-05-06 19:47:45 UTC) #6
eseidel
lgtm
6 years, 7 months ago (2014-05-06 19:56:19 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 7 months ago (2014-05-06 19:57:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/263323004/1
6 years, 7 months ago (2014-05-06 19:57:38 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 20:11:19 UTC) #10
Message was sent while issue was closed.
Change committed as 173422

Powered by Google App Engine
This is Rietveld 408576698