tools/testing/dart/test_options.dart - Issue 2633213003: Do some housekeeping in tools/testing/dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_options.dart

Issue 2633213003: Do some housekeeping in tools/testing/dart (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/test_options.dart

diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart

index e83c6706a383dc1471d3eb13a5ba136cd2d5f363..68d79880e49d586c5c944e6affd0ce73702ae490 100644

--- a/tools/testing/dart/test_options.dart

+++ b/tools/testing/dart/test_options.dart

@@ -1015,6 +1015,7 @@ Note: currently only implemented for dart2js.''',

}

print('Unknown test option $name');

exit(1);

+ return null;

Bill Hesse 2017/01/17 14:38:08 I would add a comment "unreachable" here.

asgerf 2017/01/17 14:40:06 Done.

}

List<_TestOptionSpecification> _options;

« no previous file with comments | « tools/testing/dart/pubspec.yaml ('k') | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »