Chromium Code Reviews Chromium Code Reviews
Issue 2633213003:
Do some housekeeping in tools/testing/dart (Closed)
| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file |
| 2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
| 3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
| 4 | 4 |
| 5 library test_options_parser; | 5 library test_options_parser; |
| 6 | 6 |
| 7 import "dart:io"; | 7 import "dart:io"; |
| 8 import "drt_updater.dart"; | 8 import "drt_updater.dart"; |
| 9 import "test_suite.dart"; | 9 import "test_suite.dart"; |
| 10 import "path.dart"; | 10 import "path.dart"; |
| (...skipping 997 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1008 * Find the test option specification for a given option key. | 1008 * Find the test option specification for a given option key. |
| 1009 */ | 1009 */ |
| 1010 _TestOptionSpecification _getSpecification(String name) { | 1010 _TestOptionSpecification _getSpecification(String name) { |
| 1011 for (var option in _options) { | 1011 for (var option in _options) { |
| 1012 if (option.keys.contains(name)) { | 1012 if (option.keys.contains(name)) { |
| 1013 return option; | 1013 return option; |
| 1014 } | 1014 } |
| 1015 } | 1015 } |
| 1016 print('Unknown test option $name'); | 1016 print('Unknown test option $name'); |
| 1017 exit(1); | 1017 exit(1); |
| 1018 return null; | |
|
Bill Hesse
2017/01/17 14:38:08
I would add a comment "unreachable" here.
asgerf
2017/01/17 14:40:06
Done.
| |
| 1018 } | 1019 } |
| 1019 | 1020 |
| 1020 List<_TestOptionSpecification> _options; | 1021 List<_TestOptionSpecification> _options; |
| 1021 } | 1022 } |
| OLD | NEW |
