Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: test/mjsunit/wasm/instantiate-module-basic.js

Issue 2633153002: [wasm] Catch attempt to export non-existent memory (Closed)
Patch Set: Added TODO Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/wasm/module-decoder.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --expose-wasm 5 // Flags: --expose-wasm
6 6
7 load("test/mjsunit/wasm/wasm-constants.js"); 7 load("test/mjsunit/wasm/wasm-constants.js");
8 load("test/mjsunit/wasm/wasm-module-builder.js"); 8 load("test/mjsunit/wasm/wasm-module-builder.js");
9 9
10 let kReturnValue = 17; 10 let kReturnValue = 17;
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 print("MustBeMemory..."); 234 print("MustBeMemory...");
235 var memory = new ArrayBuffer(65536); 235 var memory = new ArrayBuffer(65536);
236 let builder = new WasmModuleBuilder(); 236 let builder = new WasmModuleBuilder();
237 builder.addImportedMemory("", "memory"); 237 builder.addImportedMemory("", "memory");
238 238
239 let module = new WebAssembly.Module(builder.toBuffer()); 239 let module = new WebAssembly.Module(builder.toBuffer());
240 240
241 241
242 assertThrows(() => new WebAssembly.Instance(module, {"":{memory:memory}}), Web Assembly.LinkError); 242 assertThrows(() => new WebAssembly.Instance(module, {"":{memory:memory}}), Web Assembly.LinkError);
243 })(); 243 })();
244
245 (function TestNoMemoryToExport() {
246 let builder = new WasmModuleBuilder();
247 builder.exportMemoryAs('memory');
248 assertThrows(() => builder.instantiate(), WebAssembly.CompileError);
249 })();
OLDNEW
« no previous file with comments | « src/wasm/module-decoder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698