Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h

Issue 2633143002: SVG objects with same idrefs conflict when under different shadow root (Closed)
Patch Set: ensureSVGTreeScopedResources(); add comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h
diff --git a/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h b/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h
index 7a4bce97e6db75ff5ab17775143986ea2ffa5793..f92bbcb90ee564c5de1f8acf71a0edaac8fdf994 100644
--- a/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h
+++ b/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.h
@@ -25,15 +25,11 @@
#include "platform/geometry/FloatPoint.h"
#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
-#include "wtf/HashMap.h"
#include "wtf/HashSet.h"
-#include "wtf/text/AtomicStringHash.h"
namespace blink {
class Document;
-class Element;
-class LayoutSVGResourceContainer;
class SVGElement;
class SVGSVGElement;
class SubtreeLayoutScope;
@@ -43,7 +39,6 @@ class SVGDocumentExtensions
WTF_MAKE_NONCOPYABLE(SVGDocumentExtensions);
public:
- typedef HeapHashSet<Member<Element>> SVGPendingElements;
explicit SVGDocumentExtensions(Document*);
~SVGDocumentExtensions();
@@ -54,10 +49,6 @@ class SVGDocumentExtensions
// needs applying.
void addWebAnimationsPendingSVGElement(SVGElement&);
- void addResource(const AtomicString& id, LayoutSVGResourceContainer*);
- void removeResource(const AtomicString& id);
- LayoutSVGResourceContainer* resourceById(const AtomicString& id) const;
-
static void serviceOnAnimationFrame(Document&);
void startAnimations();
@@ -88,9 +79,6 @@ class SVGDocumentExtensions
HeapHashSet<Member<SVGSVGElement>> m_timeContainers;
using SVGElementSet = HeapHashSet<Member<SVGElement>>;
SVGElementSet m_webAnimationsPendingSVGElements;
- HashMap<AtomicString, LayoutSVGResourceContainer*> m_resources;
- // Resources that are pending.
- HeapHashMap<AtomicString, Member<SVGPendingElements>> m_pendingResources;
SVGResourcesCache m_resourcesCache;
// Root SVG elements with relative length descendants.
HeapHashSet<Member<SVGSVGElement>> m_relativeLengthSVGRoots;
@@ -100,18 +88,6 @@ class SVGDocumentExtensions
#endif
public:
- // This HashMap contains a list of pending resources. Pending resources, are
- // such which are referenced by any object in the SVG document, but do NOT
- // exist yet.
- // For instance, dynamically build gradients / patterns / clippers...
- void addPendingResource(const AtomicString& id, Element*);
- bool hasPendingResource(const AtomicString& id) const;
- bool isElementPendingResources(Element*) const;
- bool isElementPendingResource(Element*, const AtomicString& id) const;
- void clearHasPendingResourcesIfPossible(Element*);
- void removeElementFromPendingResources(Element*);
- SVGPendingElements* removePendingResource(const AtomicString& id);
-
void serviceAnimations();
};
« no previous file with comments | « third_party/WebKit/Source/core/svg/BUILD.gn ('k') | third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698