third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h - Issue 2633143002: SVG objects with same idrefs conflict when under different shadow root

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

Issue 2633143002: SVG objects with same idrefs conflict when under different shadow root (Closed)

Patch Set: ensureSVGTreeScopedResources(); add comment Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/TreeScope.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

index 7dbedb1510eff2c7f6a7b63323f613e61350b091..0461b7cf2b909a9e96beaabc1f42b96e88740faa 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.h

@@ -21,7 +21,7 @@

#define LayoutSVGResourceContainer_h

#include "core/layout/svg/LayoutSVGHiddenContainer.h"

-#include "core/svg/SVGDocumentExtensions.h"

+#include "core/svg/SVGTreeScopeResources.h"

namespace blink {

@@ -120,7 +120,7 @@ inline LayoutSVGResourceContainer* getLayoutSVGResourceContainerById(

return nullptr;

if (LayoutSVGResourceContainer* layoutResource =

- treeScope.document().accessSVGExtensions().resourceById(id))

+ treeScope.ensureSVGTreeScopedResources().resourceById(id))

return layoutResource;

return nullptr;