SVG objects with same idrefs conflict when under different shadow root

third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 13 matching lines @@
  */
 
 #include "core/svg/animation/SVGSMILElement.h"
 
 #include "bindings/core/v8/ScriptEventListener.h"
 #include "core/XLinkNames.h"
 #include "core/dom/Document.h"
 #include "core/dom/TaskRunnerHelper.h"
 #include "core/events/Event.h"
 #include "core/events/EventListener.h"
-#include "core/svg/SVGDocumentExtensions.h"
 #include "core/svg/SVGSVGElement.h"
+#include "core/svg/SVGTreeScopeResources.h"
 #include "core/svg/SVGURIReference.h"
 #include "core/svg/animation/SMILTimeContainer.h"
 #include "platform/heap/Handle.h"
 #include "wtf/MathExtras.h"
 #include "wtf/StdLibExtras.h"
 #include "wtf/Vector.h"
 #include <algorithm>
 
 namespace blink {
 
@@ skipping 155 matching lines @@
       target && target->isSVGElement() ? toSVGElement(target) : nullptr;
 
   if (svgTarget && !svgTarget->isConnected())
     svgTarget = nullptr;
 
   if (svgTarget != targetElement())
     setTargetElement(svgTarget);
 
   if (!svgTarget) {
     // Do not register as pending if we are already pending this resource.
-    if (document().accessSVGExtensions().isElementPendingResource(this, id))
+    if (treeScope().ensureSVGTreeScopedResources().isElementPendingResource(
+            this, id))
       return;
-
     if (!id.isEmpty()) {
-      document().accessSVGExtensions().addPendingResource(id, this);
-      ASSERT(hasPendingResources());
+      treeScope().ensureSVGTreeScopedResources().addPendingResource(id, this);
+      DCHECK(hasPendingResources());
     }
   } else {
     // Register us with the target in the dependencies map. Any change of
     // hrefElement that leads to relayout/repainting now informs us, so we can
     // react to it.
     addReferenceTo(svgTarget);
   }
   connectEventBaseConditions();
 }
 
@@ skipping 336 matching lines @@
 
 void SVGSMILElement::connectEventBaseConditions() {
   disconnectEventBaseConditions();
   for (unsigned n = 0; n < m_conditions.size(); ++n) {
     Condition* condition = m_conditions[n].get();
     if (condition->getType() == Condition::EventBase) {
       ASSERT(!condition->syncBase());
       SVGElement* eventBase = eventBaseFor(*condition);
       if (!eventBase) {
         if (!condition->baseID().isEmpty() &&
-            !document().accessSVGExtensions().isElementPendingResource(
-                this, AtomicString(condition->baseID())))
-          document().accessSVGExtensions().addPendingResource(
+            !treeScope()
+                 .ensureSVGTreeScopedResources()
+                 .isElementPendingResource(this,
+                                           AtomicString(condition->baseID())))
+          treeScope().ensureSVGTreeScopedResources().addPendingResource(
               AtomicString(condition->baseID()), this);
         continue;
       }
       ASSERT(!condition->eventListener());
       condition->setEventListener(
           ConditionEventListener::create(this, condition));
       eventBase->addEventListener(AtomicString(condition->name()),
                                   condition->eventListener(), false);
       addReferenceTo(eventBase);
     }
@@ skipping 723 matching lines @@
 DEFINE_TRACE(SVGSMILElement) {
   visitor->trace(m_targetElement);
   visitor->trace(m_timeContainer);
   visitor->trace(m_conditions);
   visitor->trace(m_syncBaseDependents);
   SVGElement::trace(visitor);
   SVGTests::trace(visitor);
 }
 
 }  // namespace blink