SVG objects with same idrefs conflict when under different shadow root

third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp

 /*
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "core/layout/svg/LayoutSVGResourceContainer.h"
 
 #include "core/SVGElementTypeHelpers.h"
 #include "core/layout/svg/LayoutSVGResourceClipper.h"
 #include "core/layout/svg/LayoutSVGResourceFilter.h"
 #include "core/layout/svg/LayoutSVGResourceMasker.h"
 #include "core/layout/svg/SVGResources.h"
 #include "core/layout/svg/SVGResourcesCache.h"
 #include "core/svg/SVGElementProxy.h"
+#include "core/svg/SVGTreeScopeResources.h"
 #include "wtf/AutoReset.h"
 
 namespace blink {
 
-static inline SVGDocumentExtensions& svgExtensionsFromElement(
+static inline SVGTreeScopeResources& svgTreeScopeResourcesFromElement(
     Element* element) {
-  ASSERT(element);
-  return element->document().accessSVGExtensions();
+  DCHECK(element);
+  return element->treeScope().accessSVGTreeScopedResources();
 }
 
 LayoutSVGResourceContainer::LayoutSVGResourceContainer(SVGElement* node)
     : LayoutSVGHiddenContainer(node),
       m_isInLayout(false),
       m_id(node->getIdAttribute()),
       m_invalidationMask(0),
       m_registered(false),
       m_isInvalidating(false) {}
 
@@ skipping 24 matching lines @@
 }
 
 void LayoutSVGResourceContainer::willBeDestroyed() {
   // Detach all clients referring to this resource. If the resource itself is
   // a client, it will be detached from any such resources by the call to
   // LayoutSVGHiddenContainer::willBeDestroyed() below.
   detachAllClients();
 
   LayoutSVGHiddenContainer::willBeDestroyed();
   if (m_registered)
-    svgExtensionsFromElement(element()).removeResource(m_id);
+    svgTreeScopeResourcesFromElement(element()).removeResource(m_id);
 }
 
 void LayoutSVGResourceContainer::styleDidChange(StyleDifference diff,
                                                 const ComputedStyle* oldStyle) {
   LayoutSVGHiddenContainer::styleDidChange(diff, oldStyle);
 
   if (!m_registered) {
     m_registered = true;
     registerResource();
   }
 }
 
 void LayoutSVGResourceContainer::detachAllClients() {
   for (auto* client : m_clients) {
     // Unlink the resource from the client's SVGResources. (The actual
     // removal will be signaled after processing all the clients.)
     SVGResources* resources =
         SVGResourcesCache::cachedResourcesForLayoutObject(client);
     // Or else the client wouldn't be in the list in the first place.
     DCHECK(resources);
     resources->resourceDestroyed(this);
 
     // Add a pending resolution based on the id of the old resource.
     Element* clientElement = toElement(client->node());
-    svgExtensionsFromElement(clientElement)
+    svgTreeScopeResourcesFromElement(clientElement)
         .addPendingResource(m_id, clientElement);
   }
 
   removeAllClientsFromCache();
 }
 
 void LayoutSVGResourceContainer::idChanged() {
   // Invalidate all our current clients.
   removeAllClientsFromCache();
 
   // Remove old id, that is guaranteed to be present in cache.
-  SVGDocumentExtensions& extensions = svgExtensionsFromElement(element());
-  extensions.removeResource(m_id);
+  SVGTreeScopeResources& treeScopeResources =
+      svgTreeScopeResourcesFromElement(element());
+  treeScopeResources.removeResource(m_id);
   m_id = element()->getIdAttribute();
 
   registerResource();
 }
 
 void LayoutSVGResourceContainer::markAllClientsForInvalidation(
     InvalidationMode mode) {
   if (m_isInvalidating)
     return;
   SVGElementProxySet* proxySet = elementProxySet();
@@ skipping 75 matching lines @@
 
   setNeedsLayoutAndFullPaintInvalidation(
       LayoutInvalidationReason::SvgResourceInvalidated, MarkContainerChain,
       layoutScope);
 
   if (everHadLayout())
     removeAllClientsFromCache();
 }
 
 void LayoutSVGResourceContainer::registerResource() {
-  SVGDocumentExtensions& extensions = svgExtensionsFromElement(element());
-  if (!extensions.hasPendingResource(m_id)) {
-    extensions.addResource(m_id, this);
+  SVGTreeScopeResources& treeScopeResources =
+      svgTreeScopeResourcesFromElement(element());
+  if (!treeScopeResources.hasPendingResource(m_id)) {
+    treeScopeResources.addResource(m_id, this);
     return;
   }
 
-  SVGDocumentExtensions::SVGPendingElements* clients(
-      extensions.removePendingResource(m_id));
+  SVGTreeScopeResources::SVGPendingElements* clients(
+      treeScopeResources.removePendingResource(m_id));
 
   // Cache us with the new id.
-  extensions.addResource(m_id, this);
+  treeScopeResources.addResource(m_id, this);
 
   // Update cached resources of pending clients.
   for (const auto& pendingClient : *clients) {
     DCHECK(pendingClient->hasPendingResources());
-    extensions.clearHasPendingResourcesIfPossible(pendingClient);
+    treeScopeResources.clearHasPendingResourcesIfPossible(pendingClient);
     LayoutObject* layoutObject = pendingClient->layoutObject();
     if (!layoutObject)
       continue;
     DCHECK(layoutObject->isSVG() && (resourceType() != FilterResourceType ||
                                      !layoutObject->isSVGRoot()));
 
     StyleDifference diff;
     diff.setNeedsFullLayout();
     SVGResourcesCache::clientStyleChanged(layoutObject, diff,
                                           layoutObject->styleRef());
@@ skipping 69 matching lines @@
       // This will process the rest of the ancestors.
       toLayoutSVGResourceContainer(current)->removeAllClientsFromCache();
       break;
     }
 
     current = current->parent();
   }
 }
 
 }  // namespace blink