SVG objects with same idrefs conflict when under different shadow root

third_party/WebKit/Source/core/dom/TreeScope.h

 /*
  * Copyright (C) 2011 Google Inc. All Rights Reserved.
  * Copyright (C) 2012 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 25 matching lines @@
 
 namespace blink {
 
 class ContainerNode;
 class DOMSelection;
 class Document;
 class Element;
 class HTMLMapElement;
 class HitTestResult;
 class IdTargetObserverRegistry;
+class SVGTreeScopeResources;
 class ScopedStyleResolver;
 class Node;
 
 // A class which inherits both Node and TreeScope must call clearRareData() in
 // its destructor so that the Node destructor no longer does problematic
 // NodeList cache manipulation in the destructor.
 class CORE_EXPORT TreeScope : public GarbageCollectedMixin {
  public:
   TreeScope* parentTreeScope() const { return m_parentTreeScope; }
 
@@ skipping 64 matching lines @@
   Element* getElementByAccessKey(const String& key) const;
 
   DECLARE_VIRTUAL_TRACE();
 
   ScopedStyleResolver* scopedStyleResolver() const {
     return m_scopedStyleResolver.get();
   }
   ScopedStyleResolver& ensureScopedStyleResolver();
   void clearScopedStyleResolver();
 
+  const SVGTreeScopeResources* svgExtensions();
+  SVGTreeScopeResources& accessSVGTreeScopedResources();

[pdr., 2017/01/23 04:34:12]

optional: ensureSVGTreeScopedResources so it's more obvious that this does work?

I'd be okay with leaving this for a followup, or not doing it at all on the
basis that the current code uses access*. Grepping around the codebase, ensure*
just seems to be preferred.

[fs, 2017/01/23 11:18:24]

I don't see why not - we're replacing all instances anyway so... Done. Dropped
the svgExtensions() method too since it wasn't used.

+
  protected:
   TreeScope(ContainerNode&, Document&);
   TreeScope(Document&);
   virtual ~TreeScope();
 
   void setDocument(Document& document) { m_document = &document; }
   void setParentTreeScope(TreeScope&);
   void setNeedsStyleRecalcForViewportUnits();
 
  private:
   Member<ContainerNode> m_rootNode;
   Member<Document> m_document;
   Member<TreeScope> m_parentTreeScope;
 
   Member<DocumentOrderedMap> m_elementsById;
   Member<DocumentOrderedMap> m_imageMapsByName;
 
   Member<IdTargetObserverRegistry> m_idTargetObserverRegistry;
 
   Member<ScopedStyleResolver> m_scopedStyleResolver;
 
   mutable Member<DOMSelection> m_selection;
 
   RadioButtonGroupScope m_radioButtonGroupScope;
+
+  Member<SVGTreeScopeResources> m_svgTreeScopedResources;
 };
 
 inline bool TreeScope::hasElementWithId(const AtomicString& id) const {
   DCHECK(!id.isNull());
   return m_elementsById && m_elementsById->contains(id);
 }
 
 inline bool TreeScope::containsMultipleElementsWithId(
     const AtomicString& id) const {
   return m_elementsById && m_elementsById->containsMultiple(id);
 }
 
 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(TreeScope)
 
 HitTestResult hitTestInDocument(
     const Document*,
     int x,
     int y,
     const HitTestRequest& = HitTestRequest::ReadOnly | HitTestRequest::Active);
 
 }  // namespace blink
 
 #endif  // TreeScope_h