content/browser/loader/url_loader_factory_impl_unittest.cc - Issue 2633123002: [Mojo-Loading] OnStartLoadingResponseBody should be called after OnReceiveResponse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/url_loader_factory_impl_unittest.cc

Issue 2633123002: [Mojo-Loading] OnStartLoadingResponseBody should be called after OnReceiveResponse (Closed)

Patch Set: fix Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/url_loader_factory_impl_unittest.cc

diff --git a/content/browser/loader/url_loader_factory_impl_unittest.cc b/content/browser/loader/url_loader_factory_impl_unittest.cc

index 1e448f7d39d0e35f7305c5d0275eb56fc4c29467..9219cd5d9f05b7881abbcd8950a4d9abd7493f80 100644

--- a/content/browser/loader/url_loader_factory_impl_unittest.cc

+++ b/content/browser/loader/url_loader_factory_impl_unittest.cc

@@ -273,7 +273,7 @@ TEST_P(URLLoaderFactoryImplTest, GetFailedResponse2) {

client.RunUntilComplete();

ASSERT_FALSE(client.has_received_response());

- ASSERT_TRUE(client.response_body().is_valid());

+ ASSERT_FALSE(client.response_body().is_valid());

EXPECT_EQ(net::ERR_TIMED_OUT, client.completion_status().error_code);

EXPECT_GT(client.completion_status().encoded_data_length, 0);