Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: content/browser/loader/url_loader_factory_impl_unittest.cc

Issue 2633123002: [Mojo-Loading] OnStartLoadingResponseBody should be called after OnReceiveResponse (Closed)
Patch Set: fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/loader/test_url_loader_client.cc ('k') | content/child/url_loader_client_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/url_loader_factory_impl_unittest.cc
diff --git a/content/browser/loader/url_loader_factory_impl_unittest.cc b/content/browser/loader/url_loader_factory_impl_unittest.cc
index 1e448f7d39d0e35f7305c5d0275eb56fc4c29467..2201bb1219ee65fd7fac3a3fefab706120f4066d 100644
--- a/content/browser/loader/url_loader_factory_impl_unittest.cc
+++ b/content/browser/loader/url_loader_factory_impl_unittest.cc
@@ -182,11 +182,9 @@ TEST_P(URLLoaderFactoryImplTest, GetResponse) {
ASSERT_FALSE(client.has_received_completion());
- client.RunUntilResponseBodyArrived();
- ASSERT_TRUE(client.response_body().is_valid());
- ASSERT_FALSE(client.has_received_completion());
-
client.RunUntilComplete();
+ ASSERT_TRUE(client.response_body().is_valid());
+ ASSERT_TRUE(client.has_received_completion());
EXPECT_EQ(200, client.response_head().headers->response_code());
std::string content_type;
@@ -273,7 +271,7 @@ TEST_P(URLLoaderFactoryImplTest, GetFailedResponse2) {
client.RunUntilComplete();
ASSERT_FALSE(client.has_received_response());
- ASSERT_TRUE(client.response_body().is_valid());
+ ASSERT_FALSE(client.response_body().is_valid());
EXPECT_EQ(net::ERR_TIMED_OUT, client.completion_status().error_code);
EXPECT_GT(client.completion_status().encoded_data_length, 0);
« no previous file with comments | « content/browser/loader/test_url_loader_client.cc ('k') | content/child/url_loader_client_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698