Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 26330004: Print actual list of failing tests on Android layout test steps (Closed)

Created:
7 years, 2 months ago by Dirk Pranke
Modified:
7 years, 2 months ago
Reviewers:
Isaac (away)
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, iannucci, Peter Beverloo, bulach
Visibility:
Public.

Description

Print actual list of failing tests on Android layout test steps This changes the Android bots to mimic the behavior of the non-Android bots and to print the actual list of failing/flaky/unexpected passing tests as part of the step text. R=ilevy@chromium.org BUG=293920 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227850

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix review nit #

Patch Set 3 : more linting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -31 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 2 9 chunks +109 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dirk Pranke
adding yet a third (4th) version of this code in a different place :) ...
7 years, 2 months ago (2013-10-07 23:28:01 UTC) #1
Isaac (away)
lgtm w/ nit https://codereview.chromium.org/26330004/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/26330004/diff/1/build/android/buildbot/bb_device_steps.py#newcode270 build/android/buildbot/bb_device_steps.py:270: unexpected_failures, unexpected_flakes, unexpected_passes = \ Extend ...
7 years, 2 months ago (2013-10-09 18:27:59 UTC) #2
Dirk Pranke
On 2013/10/09 18:27:59, Isaac wrote: > lgtm w/ nit > > https://codereview.chromium.org/26330004/diff/1/build/android/buildbot/bb_device_steps.py > File build/android/buildbot/bb_device_steps.py ...
7 years, 2 months ago (2013-10-09 19:02:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/26330004/5001
7 years, 2 months ago (2013-10-09 19:04:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/26330004/10001
7 years, 2 months ago (2013-10-09 19:48:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/26330004/10001
7 years, 2 months ago (2013-10-10 00:46:26 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 01:11:27 UTC) #7
Message was sent while issue was closed.
Change committed as 227850

Powered by Google App Engine
This is Rietveld 408576698