MD Settings People: Make Enter key work for Sync Page

chrome/browser/resources/settings/people_page/sync_page.html

Index: chrome/browser/resources/settings/people_page/sync_page.html
diff --git a/chrome/browser/resources/settings/people_page/sync_page.html b/chrome/browser/resources/settings/people_page/sync_page.html
index cc64bcf11f4d2fa64b41959b3a90d8a3bef39404..fe889ef427b0a78bc5ea5fa87fe76e93d4b18ae6 100644
--- a/chrome/browser/resources/settings/people_page/sync_page.html
+++ b/chrome/browser/resources/settings/people_page/sync_page.html
@@ -1,6 +1,7 @@
 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/html/web_ui_listener_behavior.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-a11y-keys/iron-a11y-keys.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-toggle-button/paper-toggle-button.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input.html">
@@ -228,6 +229,9 @@
             <div class="list-item">
               <span>$i18nRaw{passphraseExplanationText}</span>
             </div>
+            <iron-a11y-keys id="keys" keys="enter"

[dschuyler, 2017/01/17 23:20:11]

Should this have a target=""?

[tommycli, 2017/01/18 00:51:29]

I don't think it's necessary. Our other usages don't have that:
https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people...

[dschuyler, 2017/01/23 20:00:17]

Acknowledged.

+                on-keys-pressed="onSaveNewPassphraseTap_">

[dschuyler, 2017/01/17 23:20:12]

Does this work with modified enter key presses or will they be ignored (like
shift+enter or alt+enter)?

[tommycli, 2017/01/18 00:51:30]

Unfortunately, yes, it captures modified Enter presses also. And it appears
there's no way to prevent it from doing so:
https://github.com/PolymerElements/iron-a11y-keys-behavior/issues/41

My recommendation is to let this through and I'll file a P3 bug to fix. This CL
fixes a P1 at the expense of creating a P3.

[dschuyler, 2017/01/23 20:00:17]

Thanks, I agree that trading a P1 for a P3 is a good deal.

+            </iron-a11y-keys>

[dschuyler, 2017/01/17 23:20:12]

Does "esc" work for cancelling focus? Maybe that could be a separate bug/CL if
doesn't work (or added to this CL if you prefer - which is why I'm mentioning it
here).

[tommycli, 2017/01/18 00:51:30]

It's not clear to me that esc should blur the input fields. They don't blur the
default HTML input field for instance:
http://www.w3schools.com/html/html_forms.asp

[dschuyler, 2017/01/23 20:00:17]

Acknowledged.

             <paper-input id="passphraseInput" type="password"
                 value="{{passphrase_}}"
                 placeholder="$i18n{passphrasePlaceholder}"
@@ -263,6 +267,9 @@
                 value="{{existingPassphrase_}}"
                 placeholder="$i18n{passphrasePlaceholder}"
                 error-message="$i18n{incorrectPassphraseError}">
+              <iron-a11y-keys id="keys" keys="enter"
+                  on-keys-pressed="onSubmitExistingPassphraseTap_">
+              </iron-a11y-keys>
             </paper-input>
             <paper-button id="submitExistingPassphrase"
                 on-tap="onSubmitExistingPassphraseTap_" class="action-button"