Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: ios/chrome/browser/context_menu/context_menu_egtest.mm

Issue 2632783002: Marked testContextMenuOpenInNewTabFromTallPage flaky on device. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/context_menu/context_menu_egtest.mm
diff --git a/ios/chrome/browser/context_menu/context_menu_egtest.mm b/ios/chrome/browser/context_menu/context_menu_egtest.mm
index 21b5311a671bec36ca59f9ce040289597c19207f..65c652fda9189b8c9126a576507ee7c42cd32bf0 100644
--- a/ios/chrome/browser/context_menu/context_menu_egtest.mm
+++ b/ios/chrome/browser/context_menu/context_menu_egtest.mm
@@ -174,7 +174,15 @@ void SelectTabAtIndexInCurrentMode(NSUInteger index) {
// Tests "Open in New Tab" on context menu on a link that requires scrolling
// on the page to verify that context menu can be properly triggered in the
// current screen view.
-- (void)testContextMenuOpenInNewTabFromTallPage {
+// TODO(crbug.com/681130): Re-enable this test on device.
+#if TARGET_IPHONE_SIMULATOR
+#define MAYBE_testContextMenuOpenInNewTabFromTallPage \
+ testContextMenuOpenInNewTabFromTallPage
+#else
+#define MAYBE_testContextMenuOpenInNewTabFromTallPage \
+ FLAKY_testContextMenuOpenInNewTabFromTallPage
+#endif
+- (void)MAYBE_testContextMenuOpenInNewTabFromTallPage {
// Set up test simple http server.
std::map<GURL, std::string> responses;
GURL initialURL =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698