Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 263273002: Add a ClientAction used by SyncRollbackManager to notify PSS that rollback is (Closed)

Created:
6 years, 7 months ago by haitaol1
Modified:
6 years, 7 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, albertb+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Add a ClientAction used by SyncRollbackManager to notify PSS that rollback is finished. BUG=362679 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269615

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M chrome/browser/sync/test/integration/sync_test.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sync/internal_api/sync_rollback_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sync/internal_api/sync_rollback_manager.cc View 3 chunks +14 lines, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager_base.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_unittest.cc View 1 7 chunks +21 lines, -1 line 0 comments Download
M sync/protocol/sync_protocol_error.h View 1 chunk +4 lines, -0 lines 0 comments Download
M sync/protocol/sync_protocol_error.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
haitaol1
6 years, 7 months ago (2014-05-05 19:51:39 UTC) #1
Nicolas Zea
lgtm
6 years, 7 months ago (2014-05-07 17:11:10 UTC) #2
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 7 months ago (2014-05-09 17:25:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/263273002/40001
6 years, 7 months ago (2014-05-09 17:26:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-09 19:30:21 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 20:17:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/29838)
6 years, 7 months ago (2014-05-09 20:17:24 UTC) #7
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 7 months ago (2014-05-09 21:46:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/263273002/60001
6 years, 7 months ago (2014-05-09 21:47:19 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 19:11:54 UTC) #10
Message was sent while issue was closed.
Change committed as 269615

Powered by Google App Engine
This is Rietveld 408576698