src/handles.h - Issue 2632713003: Remove ~MaybeHandle and statically assert that handles are trivially copyable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/handles.h

Issue 2632713003: Remove ~MaybeHandle and statically assert that handles are trivially copyable

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/handles.h

diff --git a/src/handles.h b/src/handles.h

index 8664a3ff890a07048936147efde2d305bcba0c70..314d0385d535b7a5312eddbb0a4b99723f1e6d3f 100644

--- a/src/handles.h

+++ b/src/handles.h

@@ -185,7 +185,6 @@ template <typename T>

class MaybeHandle final {

public:

V8_INLINE MaybeHandle() {}

- V8_INLINE ~MaybeHandle() {}

// Constructor for handling automatic up casting from Handle.

// Ex. Handle<JSArray> can be passed when MaybeHandle<Object> is expected.

« no previous file with comments | « no previous file | src/handles.cc » ('j') | no next file with comments »