Fasta analyzer AST builder.

Fasta analyzer AST builder.

R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/2d30f33187d7f67f1ea9f22750a7b8c9d03fbb98

[ahe, 2017-01-13 12:57:46]

ahe@google.com changed reviewers:
+ asgerf@google.com

[ahe, 2017-01-13 12:58:23]

Note: this isn't as complete as direct-to-kernel.

[ahe, 2017-01-19 08:52:51]

ping

[asgerf, 2017-01-19 10:13:27]

Sorry for the wait.

I'm afraid I don't have any useful comments. LGTM.

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
File pkg/fasta/lib/src/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
pkg/fasta/lib/src/analyzer/ast_builder.dart:118: toAnalyzerToken(last),
unescapeLastStringPart(last.value, quote)));
Long line

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
pkg/fasta/lib/src/analyzer/ast_builder.dart:202: $body
Please remove these prints.

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
pkg/fasta/lib/src/analyzer/ast_builder.dart:262: internalError("Unhandled
property access: ${identifierOrInvoke.runtimeType}");
Long Line™

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
File pkg/fasta/lib/src/analyzer/element_store.dart (right):

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
pkg/fasta/lib/src/analyzer/element_store.dart:135: Library library, Class
supertype, Class mixin) => internalError("not supported.");
several long lines here

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
File pkg/fasta/lib/src/analyzer/mock_element.dart (right):

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
pkg/fasta/lib/src/analyzer/mock_element.dart:71: String
getExtendedDisplayName(String shortName) => internalError("not supported.");
also long lines in this file

[ahe, 2017-01-19 10:59:45]

Thank you, Asger.

What do you mean, no useful comments? One of them had a trademark symbol. That
seems pretty legit ;-)

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
File pkg/fasta/lib/src/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
pkg/fasta/lib/src/analyzer/ast_builder.dart:118: toAnalyzerToken(last),
unescapeLastStringPart(last.value, quote)));
On 2017/01/19 10:13:26, asgerf wrote:
> Long line

Done.

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
pkg/fasta/lib/src/analyzer/ast_builder.dart:202: $body
On 2017/01/19 10:13:26, asgerf wrote:
> Please remove these prints.

Done.

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
pkg/fasta/lib/src/analyzer/ast_builder.dart:262: internalError("Unhandled
property access: ${identifierOrInvoke.runtimeType}");
On 2017/01/19 10:13:26, asgerf wrote:
> Long Line™

Done.

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
File pkg/fasta/lib/src/analyzer/element_store.dart (right):

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
pkg/fasta/lib/src/analyzer/element_store.dart:135: Library library, Class
supertype, Class mixin) => internalError("not supported.");
On 2017/01/19 10:13:27, asgerf wrote:
> several long lines here

Done.

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
File pkg/fasta/lib/src/analyzer/mock_element.dart (right):

https://codereview.chromium.org/2632663002/diff/1/pkg/fasta/lib/src/analyzer/...
pkg/fasta/lib/src/analyzer/mock_element.dart:71: String
getExtendedDisplayName(String shortName) => internalError("not supported.");
On 2017/01/19 10:13:27, asgerf wrote:
> also long lines in this file

Done.

[ahe, 2017-01-19 11:00:38]

Description was changed from

==========
Fasta analyzer AST builder.
==========

to

==========
Fasta analyzer AST builder.

R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2d30f33187d7f67f1ea9f22750a7b8c9d03fbb98
==========

[ahe, 2017-01-19 11:00:39]

Committed patchset #2 (id:20001) manually as
2d30f33187d7f67f1ea9f22750a7b8c9d03fbb98 (presubmit successful).