Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4056)

Unified Diff: chrome/browser/ui/views/external_protocol_dialog.cc

Issue 2632653002: MacViews: Enable views based External Protocol dialog behind secondary-ui-md flag. (Closed)
Patch Set: Fix chromeos Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/external_protocol_dialog.cc
diff --git a/chrome/browser/ui/views/external_protocol_dialog.cc b/chrome/browser/ui/views/external_protocol_dialog.cc
index 1cfc6c81bc2e221940b17399f9486d9d55ab15a2..740f88b32d2fe87cb3d28b8dac0e74d53c3c2c31 100644
--- a/chrome/browser/ui/views/external_protocol_dialog.cc
+++ b/chrome/browser/ui/views/external_protocol_dialog.cc
@@ -27,13 +27,13 @@ const int kMessageWidth = 400;
} // namespace
-///////////////////////////////////////////////////////////////////////////////
-// ExternalProtocolHandler
+namespace chrome {
-// static
-void ExternalProtocolHandler::RunExternalProtocolDialog(
- const GURL& url, int render_process_host_id, int routing_id,
- ui::PageTransition page_transition, bool has_user_gesture) {
+void RunExternalProtocolDialogViews(const GURL& url,
tapted 2017/01/17 21:17:13 consider wrapping this entire method in #if !defi
+ int render_process_host_id,
+ int routing_id,
+ ui::PageTransition page_transition,
+ bool has_user_gesture) {
std::unique_ptr<ExternalProtocolDialogDelegate> delegate(
new ExternalProtocolDialogDelegate(url, render_process_host_id,
routing_id));
@@ -47,6 +47,8 @@ void ExternalProtocolHandler::RunExternalProtocolDialog(
routing_id);
}
+} // namespace chrome
+
///////////////////////////////////////////////////////////////////////////////
// ExternalProtocolDialog

Powered by Google App Engine
This is Rietveld 408576698