Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1679)

Unified Diff: chrome/browser/ui/views/external_protocol_dialog.cc

Issue 2632653002: MacViews: Enable views based External Protocol dialog behind secondary-ui-md flag. (Closed)
Patch Set: Address review. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/external_protocol_dialog_views_mac.mm ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/external_protocol_dialog.cc
diff --git a/chrome/browser/ui/views/external_protocol_dialog.cc b/chrome/browser/ui/views/external_protocol_dialog.cc
index 1cfc6c81bc2e221940b17399f9486d9d55ab15a2..1feeb32b83fba8c287eb277abca2e57f55223c07 100644
--- a/chrome/browser/ui/views/external_protocol_dialog.cc
+++ b/chrome/browser/ui/views/external_protocol_dialog.cc
@@ -15,6 +15,7 @@
#include "components/constrained_window/constrained_window_views.h"
#include "content/public/browser/web_contents.h"
#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/ui_features.h"
#include "ui/gfx/text_elider.h"
#include "ui/views/controls/message_box_view.h"
#include "ui/views/widget/widget.h"
@@ -30,6 +31,9 @@ const int kMessageWidth = 400;
///////////////////////////////////////////////////////////////////////////////
// ExternalProtocolHandler
+#if !defined(OS_MACOSX) || BUILDFLAG(MAC_VIEWS_BROWSER)
+// This should be kept in sync with RunExternalProtocolDialogViews in
msw 2017/01/24 08:39:37 It'd be nice to avoid this duplication, is it toug
karandeepb 2017/01/24 08:43:57 It isn't actually. The rationale for this is that
+// external_protocol_dialog_views_mac.mm.
// static
void ExternalProtocolHandler::RunExternalProtocolDialog(
const GURL& url, int render_process_host_id, int routing_id,
@@ -46,6 +50,7 @@ void ExternalProtocolHandler::RunExternalProtocolDialog(
new ExternalProtocolDialog(std::move(delegate), render_process_host_id,
routing_id);
}
+#endif // !OS_MACOSX || MAC_VIEWS_BROWSER
///////////////////////////////////////////////////////////////////////////////
// ExternalProtocolDialog
« no previous file with comments | « chrome/browser/ui/cocoa/external_protocol_dialog_views_mac.mm ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698