MacViews: Enable views based External Protocol dialog behind secondary-ui-md flag.

chrome/browser/ui/views/external_protocol_dialog.cc

Index: chrome/browser/ui/views/external_protocol_dialog.cc
diff --git a/chrome/browser/ui/views/external_protocol_dialog.cc b/chrome/browser/ui/views/external_protocol_dialog.cc
index 1cfc6c81bc2e221940b17399f9486d9d55ab15a2..703c8bda02360d0664ad62c110d8c1f4478112b7 100644
--- a/chrome/browser/ui/views/external_protocol_dialog.cc
+++ b/chrome/browser/ui/views/external_protocol_dialog.cc
@@ -15,6 +15,7 @@
 #include "components/constrained_window/constrained_window_views.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/base/l10n/l10n_util.h"
+#include "ui/base/ui_features.h"
 #include "ui/gfx/text_elider.h"
 #include "ui/views/controls/message_box_view.h"
 #include "ui/views/widget/widget.h"
@@ -30,6 +31,9 @@ const int kMessageWidth = 400;
 ///////////////////////////////////////////////////////////////////////////////
 // ExternalProtocolHandler
 
+#if !defined(OS_MACOSX) || BUILDFLAG(MAC_VIEWS_BROWSER)

[karandeepb, 2017/01/24 06:12:23]

Should we think of having 

#define COCOA_BROWSER #defined(OS_MACOSX) && !BUILDFLAG(MAC_VIEWS_BROWSER)
somewhere

as this pattern becomes more common.

+// This should be kept in sync with RunExternalProtocolDialogViews in
+// external_protocol_dialog_views_mac.mm.
 // static
 void ExternalProtocolHandler::RunExternalProtocolDialog(
     const GURL& url, int render_process_host_id, int routing_id,
@@ -46,6 +50,7 @@ void ExternalProtocolHandler::RunExternalProtocolDialog(
   new ExternalProtocolDialog(std::move(delegate), render_process_host_id,
                              routing_id);
 }
+#endif

[tapted, 2017/01/24 04:02:43]

nit: // !OS_MACOSX || MAC_VIEWS_BROWSER

[karandeepb, 2017/01/24 06:12:23]

Done.

 
 ///////////////////////////////////////////////////////////////////////////////
 // ExternalProtocolDialog