Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: chrome/browser/ui/browser_dialogs.h

Issue 2632653002: MacViews: Enable views based External Protocol dialog behind secondary-ui-md flag. (Closed)
Patch Set: Fix chromeos Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_DIALOGS_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
6 #define CHROME_BROWSER_UI_BROWSER_DIALOGS_H_ 6 #define CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
7 7
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/callback.h" 12 #include "base/callback.h"
13 #include "build/build_config.h" 13 #include "build/build_config.h"
14 #include "chrome/browser/ui/bookmarks/bookmark_editor.h" 14 #include "chrome/browser/ui/bookmarks/bookmark_editor.h"
15 #include "third_party/skia/include/core/SkColor.h" 15 #include "third_party/skia/include/core/SkColor.h"
16 #include "ui/base/page_transition_types.h"
16 #include "ui/gfx/native_widget_types.h" 17 #include "ui/gfx/native_widget_types.h"
17 18
18 #if defined(OS_CHROMEOS) 19 #if defined(OS_CHROMEOS)
19 #include "chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h" 20 #include "chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h"
20 #endif // OS_CHROMEOS 21 #endif // OS_CHROMEOS
21 22
22 class Browser; 23 class Browser;
23 class ContentSettingBubbleModel; 24 class ContentSettingBubbleModel;
24 class GURL; 25 class GURL;
25 class LoginHandler; 26 class LoginHandler;
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 // Creates a toolkit-views based LoginHandler (e.g. HTTP-Auth dialog). 144 // Creates a toolkit-views based LoginHandler (e.g. HTTP-Auth dialog).
144 LoginHandler* CreateLoginHandlerViews(net::AuthChallengeInfo* auth_info, 145 LoginHandler* CreateLoginHandlerViews(net::AuthChallengeInfo* auth_info,
145 net::URLRequest* request); 146 net::URLRequest* request);
146 147
147 // Shows the toolkit-views based BookmarkEditor. 148 // Shows the toolkit-views based BookmarkEditor.
148 void ShowBookmarkEditorViews(gfx::NativeWindow parent_window, 149 void ShowBookmarkEditorViews(gfx::NativeWindow parent_window,
149 Profile* profile, 150 Profile* profile,
150 const BookmarkEditor::EditDetails& details, 151 const BookmarkEditor::EditDetails& details,
151 BookmarkEditor::Configuration configuration); 152 BookmarkEditor::Configuration configuration);
152 153
154 // Shows the toolkit-views based External Protocol dialog.
155 void RunExternalProtocolDialogViews(const GURL& url,
tapted 2017/01/17 21:17:13 Does this need to be here, or can it be a data mem
karandeepb 2017/01/19 03:59:43 It can be a static member function. Don't think it
tapted 2017/01/20 05:53:52 ExternalProtocolDialog currently uses static class
156 int render_process_host_id,
157 int routing_id,
158 ui::PageTransition page_transition,
159 bool has_user_gesture);
160
153 void ShowPaymentRequestDialog(payments::PaymentRequest* request); 161 void ShowPaymentRequestDialog(payments::PaymentRequest* request);
154 162
155 #if defined(OS_MACOSX) 163 #if defined(OS_MACOSX)
156 164
157 // This is a class so that it can be friended from ContentSettingBubbleContents, 165 // This is a class so that it can be friended from ContentSettingBubbleContents,
158 // which allows it to call SetAnchorRect(). 166 // which allows it to call SetAnchorRect().
159 class ContentSettingBubbleViewsBridge { 167 class ContentSettingBubbleViewsBridge {
160 public: 168 public:
161 static void Show(gfx::NativeView parent_view, 169 static void Show(gfx::NativeView parent_view,
162 ContentSettingBubbleModel* model, 170 ContentSettingBubbleModel* model,
(...skipping 24 matching lines...) Expand all
187 using BubbleShowPtr = 195 using BubbleShowPtr =
188 void (*)(content::WebContents*, 196 void (*)(content::WebContents*,
189 const std::vector<arc::ArcNavigationThrottle::AppInfo>&, 197 const std::vector<arc::ArcNavigationThrottle::AppInfo>&,
190 const IntentPickerResponse&); 198 const IntentPickerResponse&);
191 199
192 BubbleShowPtr ShowIntentPickerBubble(); 200 BubbleShowPtr ShowIntentPickerBubble();
193 201
194 #endif // OS_CHROMEOS 202 #endif // OS_CHROMEOS
195 203
196 #endif // CHROME_BROWSER_UI_BROWSER_DIALOGS_H_ 204 #endif // CHROME_BROWSER_UI_BROWSER_DIALOGS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698