MacViews: Enable views based External Protocol dialog behind secondary-ui-md flag.

chrome/browser/ui/cocoa/external_protocol_dialog_views_mac.mm

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/external_protocol/external_protocol_handler.h"

[tapted, 2017/01/24 04:02:43]

I would have expected a presubmit to warn against this, I think only 

chrome/browser/ui/cocoa/external_protocol_dialog_[^_.]*.h

should be permitted as the separated-out header

[karandeepb, 2017/01/24 06:12:23]

I was following the example in external_protocol_android.cc -
https://cs.chromium.org/chromium/src/chrome/browser/ui/android/external_proto....


This seems to be allowed by the google style guide as well. Quoting:
"In dir/foo.cc or dir/foo_test.cc, whose main purpose is to implement or test
the stuff in dir2/foo2.h, order your includes as follows:

dir2/foo2.h.
C system files.
C++ system files.
Google .h files.

dir/foo.cc and dir2/foo2.h are usually in the same directory (e.g.
base/basictypes_test.cc and base/basictypes.h), but may sometimes be in
different directories too (e.g. testing/base/internal/gmock-cardinalities.cc and
testing/base/public/gmock-cardinalities.h).
"

from
https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#....

+
+#import "chrome/browser/ui/cocoa/external_protocol_dialog.h"
+#include "chrome/browser/ui/external_protocol_dialog_delegate.h"
+#include "chrome/browser/ui/views/external_protocol_dialog.h"
+#include "ui/base/material_design/material_design_controller.h"
+
+namespace {
+
+// Note: This is duplicated from
+// chrome/browser/ui/views/external_protocol_dialog.cc.
+void RunExternalProtocolDialogViews(const GURL& url,
+                                    int render_process_host_id,
+                                    int routing_id,
+                                    ui::PageTransition page_transition,
+                                    bool has_user_gesture) {
+  std::unique_ptr<ExternalProtocolDialogDelegate> delegate(
+      new ExternalProtocolDialogDelegate(url, render_process_host_id,
+                                         routing_id));
+  if (delegate->program_name().empty()) {
+    // ShellExecute won't do anything. Don't bother warning the user.
+    return;
+  }
+
+  // Windowing system takes ownership.
+  new ExternalProtocolDialog(std::move(delegate), render_process_host_id,
+                             routing_id);
+}
+
+}  // namespace
+
+// static
+void ExternalProtocolHandler::RunExternalProtocolDialog(
+    const GURL& url,
+    int render_process_host_id,
+    int routing_id,
+    ui::PageTransition page_transition,
+    bool has_user_gesture) {
+  if (ui::MaterialDesignController::IsSecondaryUiMaterial()) {
+    RunExternalProtocolDialogViews(url, render_process_host_id, routing_id,
+                                   page_transition, has_user_gesture);
+    return;
+  }
+  [[ExternalProtocolDialogController alloc] initWithGURL:&url
+                                     renderProcessHostId:render_process_host_id
+                                               routingId:routing_id];
+}