Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: base/debug/stack_trace.h

Issue 2632643004: Remove WTFReportAssertionFailure and WTFReportBacktrace. (Closed)
Patch Set: Add Truncate() helper Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/debug/stack_trace.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/stack_trace.h
diff --git a/base/debug/stack_trace.h b/base/debug/stack_trace.h
index d4918d60654b808719ebcfdda6be74d43174f75d..f87db6cb67cdfed8060bfe8b11efe8cf3a6e770a 100644
--- a/base/debug/stack_trace.h
+++ b/base/debug/stack_trace.h
@@ -68,7 +68,8 @@ class BASE_EXPORT StackTrace {
// Copying and assignment are allowed with the default functions.
- ~StackTrace();
+ // Returns a copy of this StackTrace, but with at most |max_entries|.
+ StackTrace Truncate(size_t max_entries) const;
esprehn 2017/01/26 22:55:45 This does mean we waste time inside backtrace() fi
Wez 2017/01/27 01:29:58 Fair point; let's optimize that if it proves to be
// Gets an array of instruction pointer values. |*count| will be set to the
// number of elements in the returned array.
@@ -96,6 +97,7 @@ class BASE_EXPORT StackTrace {
// doesn't give much more information.
static const int kMaxTraces = 62;
+ protected:
void* trace_[kMaxTraces];
// The number of valid frames in |trace_|.
« no previous file with comments | « no previous file | base/debug/stack_trace.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698