Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/mirrors_used.dart

Issue 2632643002: Remove LibraryEntity.libraryName (Closed)
Patch Set: Replace libraryOrScriptName with name Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/compiler/lib/src/elements/elements.dart ('K') | « pkg/compiler/lib/src/kernel/world_builder.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/mirrors_used.dart
diff --git a/pkg/compiler/lib/src/mirrors_used.dart b/pkg/compiler/lib/src/mirrors_used.dart
index 08c8750e3fb6fc8ac762141b439e164e7f9758c2..c1fde6e75bd76104b4d405877f4a1f5ff8c1744d 100644
--- a/pkg/compiler/lib/src/mirrors_used.dart
+++ b/pkg/compiler/lib/src/mirrors_used.dart
@@ -456,7 +456,7 @@ class MirrorUsageBuilder {
String libraryNameCandiate;
for (LibraryElement l in compiler.libraryLoader.libraries) {
if (l.hasLibraryName) {
- String libraryName = l.libraryOrScriptName;
+ String libraryName = l.libraryName;
Siggi Cherem (dart-lang) 2017/02/07 23:31:53 should this one be .name too?
Johnni Winther 2017/02/08 10:27:10 No. It is a deliberate dependency on the actual li
if (string == libraryName) {
// Found an exact match.
libraryCandiate = l;
@@ -514,7 +514,7 @@ class MirrorUsageBuilder {
reporter.reportHintMessage(
spannable,
MessageKind.MIRRORS_CANNOT_RESOLVE_IN_LIBRARY,
- {'name': identifiers[0], 'library': library.libraryOrScriptName});
+ {'name': identifiers[0], 'library': library.name});
} else {
reporter.reportHintMessage(
spannable,
« pkg/compiler/lib/src/elements/elements.dart ('K') | « pkg/compiler/lib/src/kernel/world_builder.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698