Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Side by Side Diff: pkg/compiler/lib/src/elements/names.dart

Issue 2632643002: Remove LibraryEntity.libraryName (Closed)
Patch Set: Updated cf. comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/elements/modelx.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of elements; 5 part of elements;
6 6
7 /// A [Name] represents the abstraction of a Dart identifier which takes privacy 7 /// A [Name] represents the abstraction of a Dart identifier which takes privacy
8 /// and setter into account. 8 /// and setter into account.
9 // TODO(johnniwinther): Try to share logic with [Selector]. 9 // TODO(johnniwinther): Try to share logic with [Selector].
10 abstract class Name { 10 abstract class Name {
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 102
103 bool get isPrivate => true; 103 bool get isPrivate => true;
104 104
105 int get hashCode => super.hashCode + 13 * library.hashCode; 105 int get hashCode => super.hashCode + 13 * library.hashCode;
106 106
107 bool operator ==(other) { 107 bool operator ==(other) {
108 if (other is! PrivateName) return false; 108 if (other is! PrivateName) return false;
109 return super == (other) && library == other.library; 109 return super == (other) && library == other.library;
110 } 110 }
111 111
112 String toString() => '${library.libraryName}#${super.toString()}'; 112 String toString() => '${library.name}#${super.toString()}';
113 } 113 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/elements/modelx.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698