Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: pkg/compiler/lib/src/elements/entities.dart

Issue 2632643002: Remove LibraryEntity.libraryName (Closed)
Patch Set: Updated cf. comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/elements/elements.dart ('k') | pkg/compiler/lib/src/elements/modelx.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library entities; 5 library entities;
6 6
7 import '../common.dart'; 7 import '../common.dart';
8 8
9 /// Abstract interface for entities. 9 /// Abstract interface for entities.
10 /// 10 ///
11 /// Implement this directly if the entity is not a Dart language entity. 11 /// Implement this directly if the entity is not a Dart language entity.
12 /// Entities defined within the Dart language should implement [Element]. 12 /// Entities defined within the Dart language should implement [Element].
13 /// 13 ///
14 /// For instance, the JavaScript backend need to create synthetic variables for 14 /// For instance, the JavaScript backend need to create synthetic variables for
15 /// calling intercepted classes and such variables do not correspond to an 15 /// calling intercepted classes and such variables do not correspond to an
16 /// entity in the Dart source code nor in the terminology of the Dart language 16 /// entity in the Dart source code nor in the terminology of the Dart language
17 /// and should therefore implement [Entity] directly. 17 /// and should therefore implement [Entity] directly.
18 abstract class Entity implements Spannable { 18 abstract class Entity implements Spannable {
19 String get name; 19 String get name;
20 } 20 }
21 21
22 /// Stripped down super interface for library like entities. 22 /// Stripped down super interface for library like entities.
23 /// 23 ///
24 /// Currently only [LibraryElement] but later also kernel based Dart classes 24 /// Currently only [LibraryElement] but later also kernel based Dart classes
25 /// and/or Dart-in-JS classes. 25 /// and/or Dart-in-JS classes.
26 abstract class LibraryEntity extends Entity { 26 abstract class LibraryEntity extends Entity {}
27 String get libraryName;
28 }
29 27
30 /// Stripped down super interface for class like entities. 28 /// Stripped down super interface for class like entities.
31 /// 29 ///
32 /// Currently only [ClassElement] but later also kernel based Dart classes 30 /// Currently only [ClassElement] but later also kernel based Dart classes
33 /// and/or Dart-in-JS classes. 31 /// and/or Dart-in-JS classes.
34 abstract class ClassEntity extends Entity { 32 abstract class ClassEntity extends Entity {
35 bool get isClosure; 33 bool get isClosure;
36 } 34 }
37 35
38 abstract class TypeVariableEntity extends Entity { 36 abstract class TypeVariableEntity extends Entity {
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 Entity get executableContext; 95 Entity get executableContext;
98 96
99 /// The outermost member that contains this element. 97 /// The outermost member that contains this element.
100 /// 98 ///
101 /// For top level, static or instance members, the member context is the 99 /// For top level, static or instance members, the member context is the
102 /// element itself. For parameters, local variables and nested closures, the 100 /// element itself. For parameters, local variables and nested closures, the
103 /// member context is the top level, static or instance member in which it is 101 /// member context is the top level, static or instance member in which it is
104 /// defined. 102 /// defined.
105 MemberEntity get memberContext; 103 MemberEntity get memberContext;
106 } 104 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/elements/elements.dart ('k') | pkg/compiler/lib/src/elements/modelx.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698