Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Side by Side Diff: pkg/compiler/lib/src/elements/elements.dart

Issue 2632643002: Remove LibraryEntity.libraryName (Closed)
Patch Set: Replace libraryOrScriptName with name Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library elements; 5 library elements;
6 6
7 import '../common.dart'; 7 import '../common.dart';
8 import '../common/resolution.dart' show Resolution; 8 import '../common/resolution.dart' show Resolution;
9 import '../constants/constructors.dart'; 9 import '../constants/constructors.dart';
10 import '../constants/expressions.dart'; 10 import '../constants/expressions.dart';
(...skipping 1060 matching lines...) Expand 10 before | Expand all | Expand 10 after
1071 /// Returns the imports that import element into this library. 1071 /// Returns the imports that import element into this library.
1072 Iterable<ImportElement> getImportsFor(Element element); 1072 Iterable<ImportElement> getImportsFor(Element element);
1073 1073
1074 /// `true` if this library has name as given through a library tag. 1074 /// `true` if this library has name as given through a library tag.
1075 bool get hasLibraryName; 1075 bool get hasLibraryName;
1076 1076
1077 /// The library name, which is either the name given in the library tag 1077 /// The library name, which is either the name given in the library tag
1078 /// or the empty string if there is no library tag. 1078 /// or the empty string if there is no library tag.
1079 String get libraryName; 1079 String get libraryName;
1080 1080
1081 /// Returns the library name (as defined by the library tag) or for script 1081 /// Returns the library name (as defined by the library tag) or for script
Siggi Cherem (dart-lang) 2017/02/07 23:31:53 nit: script => scripts?
Johnni Winther 2017/02/08 10:27:10 Done.
1082 /// (which have no library tag) the script file name. The latter case is used 1082 /// (which have no library tag) the script file name.
1083 /// to provide a 'library name' for scripts to use for instance in dartdoc.
1084 /// 1083 ///
1085 /// Note: the returned filename is still escaped ("a%20b.dart" instead of 1084 /// Note: the returned filename is still escaped ("a%20b.dart" instead of
1086 /// "a b.dart"). 1085 /// "a b.dart").
1087 String get libraryOrScriptName; 1086 String get name;
1088 } 1087 }
1089 1088
1090 /// The implicit scope defined by a import declaration with a prefix clause. 1089 /// The implicit scope defined by a import declaration with a prefix clause.
1091 abstract class PrefixElement extends Element { 1090 abstract class PrefixElement extends Element {
1092 Element lookupLocalMember(String memberName); 1091 Element lookupLocalMember(String memberName);
1093 1092
1094 void forEachLocalMember(void f(Element member)); 1093 void forEachLocalMember(void f(Element member));
1095 1094
1096 /// Is true if this prefix belongs to a deferred import. 1095 /// Is true if this prefix belongs to a deferred import.
1097 bool get isDeferred; 1096 bool get isDeferred;
(...skipping 917 matching lines...) Expand 10 before | Expand all | Expand 10 after
2015 /// by a field. 2014 /// by a field.
2016 bool get isDeclaredByField; 2015 bool get isDeclaredByField;
2017 2016
2018 /// Returns `true` if this member is abstract. 2017 /// Returns `true` if this member is abstract.
2019 bool get isAbstract; 2018 bool get isAbstract;
2020 2019
2021 /// If abstract, [implementation] points to the overridden concrete member, 2020 /// If abstract, [implementation] points to the overridden concrete member,
2022 /// if any. Otherwise [implementation] points to the member itself. 2021 /// if any. Otherwise [implementation] points to the member itself.
2023 Member get implementation; 2022 Member get implementation;
2024 } 2023 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698