components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.h - Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.h

Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE. (Closed)

Patch Set: Fix navigation transition type. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc ('k') | components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.h

diff --git a/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.h b/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.h

index 1757b576132fff427bb901aba026e0a2e77a2904..e4dbfe12c846961fd56e1076418ecdf9d2c57c96 100644

--- a/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.h

+++ b/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle.h

@@ -41,8 +41,11 @@ class SubframeNavigationFilteringThrottle : public content::NavigationThrottle {

const char* GetNameForLogging() override;

private:

- content::NavigationThrottle::ThrottleCheckResult DeferToCalculateLoadPolicy();

- void OnCalculatedLoadPolicy(LoadPolicy policy);

+ enum class ThrottlingStage { WillStartRequest, WillRedirectRequest };

+ content::NavigationThrottle::ThrottleCheckResult DeferToCalculateLoadPolicy(

+ ThrottlingStage stage);

+ void OnCalculatedLoadPolicy(ThrottlingStage stage, LoadPolicy policy);

// Must outlive this class.

AsyncDocumentSubresourceFilter* parent_frame_filter_;