components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc - Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE. (Closed)

Patch Set: Addressed comments from csharrison@. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_google_auth_navigation_throttle.cc ('k') | components/subresource_filter/content/browser/content_subresource_filter_throttle_manager_unittest.cc » ('j') | content/browser/frame_host/render_frame_host_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

index 592d21f5d4c49963d34c9d1c7816778e3d8c9630..4269c4124eaf15c0666a97f767ee5e2f0d357e4f 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

@@ -370,7 +370,8 @@ class ContentSubresourceFilterDriverFactoryTest

content::NavigationThrottle::ThrottleCheckResult result =

simulator->GetLastThrottleCheckResult();

if (expect_cancelled) {

- EXPECT_EQ(content::NavigationThrottle::CANCEL, result);

+ EXPECT_EQ(content::NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE,

+ result);

} else {

EXPECT_EQ(content::NavigationThrottle::PROCEED, result);

simulator->Commit();