Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: content/public/browser/navigation_throttle.h

Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE. (Closed)
Patch Set: Remove surplus semicolon. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/navigation_throttle.h
diff --git a/content/public/browser/navigation_throttle.h b/content/public/browser/navigation_throttle.h
index ba49aa73a716aa81af9106d7b875df3f18fa26ac..76391291df806961d9e4ad56641014ad15c61256 100644
--- a/content/public/browser/navigation_throttle.h
+++ b/content/public/browser/navigation_throttle.h
@@ -39,6 +39,11 @@ class CONTENT_EXPORT NavigationThrottle {
// is navigated.
BLOCK_REQUEST,
+ // Blocks a navigation taking place in a subframe, and collapses the frame
+ // owner element in the parent frame (i.e. removes it from the layout). Can
+ // be be returned from WillStartRequest or WillRedirectRequest.
+ BLOCK_REQUEST_AND_COLLAPSE,
clamy 2017/01/18 15:10:55 I'm wondering whether we should add a new Throttle
engedy 2017/01/18 23:37:14 I am fine with either :-). @Nasko, WDYT?
engedy 2017/02/17 18:09:25 On second thought, I think it makes for a better a
+
// Blocks a navigation due to rules asserted by a response (for instance,
// embedding restrictions like 'X-Frame-Options'). This result will only
// be returned from WillProcessResponse.

Powered by Google App Engine
This is Rietveld 408576698