Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE. (Closed)
Patch Set: Addressed comments, made redirect response PlzNavigate-only. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
index d9f83262d3de730661f27bbaf56581dfd7af9f13..9f7471ec53221fe8d58173a0ba527bc5c286731d 100644
--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
@@ -135,6 +135,12 @@ bool WebRemoteFrameImpl::HasVerticalScrollbar() const {
return false;
}
+void WebRemoteFrameImpl::Collapse(bool collapsed) {
alexmos 2017/04/11 06:00:30 Given that this does the same thing as WebLocalFra
engedy 2017/04/11 08:06:17 Excellent suggestion, done!
+ DCHECK(GetFrame()->Owner()->IsLocal());
+ HTMLFrameOwnerElement* owner = ToHTMLFrameOwnerElement(GetFrame()->Owner());
+ owner->SetCollapsedByClient(collapsed);
+}
+
WebView* WebRemoteFrameImpl::View() const {
if (!GetFrame())
return nullptr;

Powered by Google App Engine
This is Rietveld 408576698