third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp - Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE. (Closed)

Patch Set: Addressed comments, made redirect response PlzNavigate-only. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

index 90d7742c2a7a0d82a13e9e5e742135dd53aa0b32..ea3ccd0f63f0e79e6288a79bfaf9d6f13ebd7d6c 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

@@ -159,6 +159,7 @@ void HTMLFrameOwnerElement::SetContentFrame(Frame& frame) {

DCHECK(!content_frame_ || content_frame_->Owner() != this);

// Disconnected frames should not be allowed to load.

DCHECK(isConnected());

content_frame_ = &frame;

for (ContainerNode* node = this; node; node = node->ParentOrShadowHostNode())