Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: content/public/browser/navigation_handle.h

Issue 2632633006: Implement NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE. (Closed)
Patch Set: Addressed comments from csharrison@. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 // yet. The connection info may change during the navigation (e.g. after 226 // yet. The connection info may change during the navigation (e.g. after
227 // encountering a server redirect). 227 // encountering a server redirect).
228 virtual net::HttpResponseInfo::ConnectionInfo GetConnectionInfo() = 0; 228 virtual net::HttpResponseInfo::ConnectionInfo GetConnectionInfo() = 0;
229 229
230 // Resumes a navigation that was previously deferred by a NavigationThrottle. 230 // Resumes a navigation that was previously deferred by a NavigationThrottle.
231 // Note: this may lead to the deletion of the NavigationHandle and its 231 // Note: this may lead to the deletion of the NavigationHandle and its
232 // associated NavigationThrottles. 232 // associated NavigationThrottles.
233 virtual void Resume() = 0; 233 virtual void Resume() = 0;
234 234
235 // Cancels a navigation that was previously deferred by a NavigationThrottle. 235 // Cancels a navigation that was previously deferred by a NavigationThrottle.
236 // |result| should be equal to NavigationThrottle::CANCEL or 236 // |result| should be equal to either:
237 // NavigationThrottle::CANCEL_AND_IGNORE. 237 // - NavigationThrottle::CANCEL,
238 // - NavigationThrottle::CANCEL_AND_IGNORE. or
nasko 2017/05/03 16:58:30 nit: s/./,/
engedy 2017/05/05 08:23:57 Done.
239 // - NavigationThrottle::BLOCK_REQUEST_AND_COLLAPSE.
238 // Note: this may lead to the deletion of the NavigationHandle and its 240 // Note: this may lead to the deletion of the NavigationHandle and its
239 // associated NavigationThrottles. 241 // associated NavigationThrottles.
240 virtual void CancelDeferredNavigation( 242 virtual void CancelDeferredNavigation(
241 NavigationThrottle::ThrottleCheckResult result) = 0; 243 NavigationThrottle::ThrottleCheckResult result) = 0;
242 244
243 // Returns the ID of the URLRequest associated with this navigation. Can only 245 // Returns the ID of the URLRequest associated with this navigation. Can only
244 // be called from NavigationThrottle::WillProcessResponse and 246 // be called from NavigationThrottle::WillProcessResponse and
245 // WebContentsObserver::ReadyToCommitNavigation. 247 // WebContentsObserver::ReadyToCommitNavigation.
246 // In the case of transfer navigations, this is the ID of the first request 248 // In the case of transfer navigations, this is the ID of the first request
247 // made. The transferred request's ID will not be tracked by the 249 // made. The transferred request's ID will not be tracked by the
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 297
296 // The NavigationData that the embedder returned from 298 // The NavigationData that the embedder returned from
297 // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will 299 // ResourceDispatcherHostDelegate::GetNavigationData during commit. This will
298 // be a clone of the NavigationData. 300 // be a clone of the NavigationData.
299 virtual NavigationData* GetNavigationData() = 0; 301 virtual NavigationData* GetNavigationData() = 0;
300 }; 302 };
301 303
302 } // namespace content 304 } // namespace content
303 305
304 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_ 306 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_HANDLE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698