chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html - Issue 2632633005: Fix html attributes for RTL languages on the signin email confirmation dialog.

Side by Side Diff: chrome/browser/resources/signin/signin_email_confirmation/signin_email_confirmation.html

Issue 2632633005: Fix html attributes for RTL languages on the signin email confirmation dialog. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html i18n-values="dir:textdirection;lang:language">	2 <html i18n-values="dir:textdirection;lang:language">
	Dan Beam 2017/01/13 17:13:14 does changing this to <html dir="$i18n{textdirect does changing this to <html dir="$i18n{textdirection}" lang="$i18n{language}"> work instead? msarda 2017/01/13 19:53:13 I have not tested it - I would suppose it does as Show quoted text On 2017/01/13 17:13:14, Dan Beam wrote: > does changing this to > > <html dir="$i18n{textdirection}" lang="$i18n{language}"> > > work instead? I have not tested it - I would suppose it does as it is used elsewhere in the code (see https://cs.chromium.org/search/?q=%22html+dir%3D%5C%22$i18n%7Btextdirection%7...) I thought it would be better to use the script for consistency - this is what is used in the sync_confirmation dialog which is part of the same sign-in flow - see https://cs.chromium.org/chromium/src/chrome/browser/resources/signin/sync_con... What is the preferred way - including the script i18n_template or using your proposal (<html dir="$i18n{textdirection}" lang="$i18n{language}">)? msarda 2017/01/16 08:52:58 Done. Show quoted text On 2017/01/13 19:53:13, msarda wrote: > On 2017/01/13 17:13:14, Dan Beam wrote: > > does changing this to > > > > <html dir="$i18n{textdirection}" lang="$i18n{language}"> > > > > work instead? > > I have not tested it - I would suppose it does as it is used elsewhere in the > code (see > https://cs.chromium.org/search/?q=%22html+dir%3D%5C%22$i18n%7Btextdirection%7...) > > I thought it would be better to use the script for consistency - this is what is > used in the sync_confirmation dialog which is part of the same sign-in flow - > see > https://cs.chromium.org/chromium/src/chrome/browser/resources/signin/sync_con... > > What is the preferred way - including the script i18n_template or using your > proposal (<html dir="$i18n{textdirection}" lang="$i18n{language}">)? Done.
3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <link rel="import" href="chrome://resources/html/polymer.html">	5 <link rel="import" href="chrome://resources/html/polymer.html">

6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper- button.html">	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper- button.html">

7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/ paper-radio-button.html">	7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/ paper-radio-button.html">

8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-group/p aper-radio-group.html">	8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-group/p aper-radio-group.html">

9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color. html">	9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color. html">

10 <link rel="import" href="signin_shared_css.html">	10 <link rel="import" href="signin_shared_css.html">

11 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">	11 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

12 <link rel="import" href="chrome://resources/html/cr.html">	12 <link rel="import" href="chrome://resources/html/cr.html">

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 $i18n{signinEmailConfirmationConfirmLabel}	53 $i18n{signinEmailConfirmationConfirmLabel}

54 </paper-button>	54 </paper-button>

55 <paper-button class="secondary-action" id="closeButton">	55 <paper-button class="secondary-action" id="closeButton">

56 $i18n{signinEmailConfirmationCloseLabel}	56 $i18n{signinEmailConfirmationCloseLabel}

57 </paper-button>	57 </paper-button>

58 </div>	58 </div>

59 </div>	59 </div>

60 </body>	60 </body>

61 <script src="signin_email_confirmation.js"></script>	61 <script src="signin_email_confirmation.js"></script>

62 <script src="chrome://signin-email-confirmation/strings.js"></script>	62 <script src="chrome://signin-email-confirmation/strings.js"></script>

	63 <script src="chrome://resources/js/i18n_template.js"></script>

63 </html>	64 </html>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »