Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: src/list.h

Issue 2632633002: Fix gcc error for static_cast the parameters of DCHECK_GT macro to unsigned in list.h. (Closed)
Patch Set: add error message Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/list.h
diff --git a/src/list.h b/src/list.h
index 60862e8d0289ee8ed4a6e6abe7960553032b8ffb..b59ece463efba2c64eb0ad7a1e763ef8052c9519 100644
--- a/src/list.h
+++ b/src/list.h
@@ -65,7 +65,7 @@ class List {
// backing store (e.g. Add).
inline T& operator[](int i) const {
DCHECK_LE(0, i);
- DCHECK_GT(length_, i);
+ DCHECK_GT(static_cast<unsigned>(length_), static_cast<unsigned>(i));
return data_[i];
}
inline T& at(int i) const { return operator[](i); }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698