Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: tools/foozzie/v8_foozzie.py

Issue 2632623002: [foozzie] Fix failure state for non-existing source output (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/foozzie/v8_suppressions.py » ('j') | tools/foozzie/v8_suppressions.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/foozzie/v8_foozzie.py
diff --git a/tools/foozzie/v8_foozzie.py b/tools/foozzie/v8_foozzie.py
index 04a7bbe577bf61e63a7c8ab8b2821fcb9e6ed255..f863ceb9c84b91e0183413b00537350211106066 100755
--- a/tools/foozzie/v8_foozzie.py
+++ b/tools/foozzie/v8_foozzie.py
@@ -8,7 +8,6 @@ V8 correctness fuzzer launcher script.
"""
import argparse
-import hashlib
import itertools
import json
import os
@@ -37,10 +36,6 @@ TIMEOUT = 3
RETURN_PASS = 0
RETURN_FAIL = 2
-# The number of hex digits used from the hash of the original source file path.
-# Keep the number small to avoid duplicate explosion.
-SOURCE_HASH_LENGTH = 3
-
BASE_PATH = os.path.dirname(os.path.abspath(__file__))
PREAMBLE = [
os.path.join(BASE_PATH, 'v8_mock.js'),
@@ -248,7 +243,7 @@ def main():
if fail_bailout(second_config_output, suppress.ignore_by_output2):
return RETURN_FAIL
- difference, source = suppress.diff(
+ difference, source_key = suppress.diff(
first_config_output.stdout, second_config_output.stdout)
if difference:
# The first three entries will be parsed by clusterfuzz. Format changes
@@ -257,7 +252,7 @@ def main():
second_config_label = '%s,%s' % (options.second_arch, options.second_config)
print FAILURE_TEMPLATE % dict(
configs='%s:%s' % (first_config_label, second_config_label),
- sources=hashlib.sha1(source).hexdigest()[:SOURCE_HASH_LENGTH],
+ sources=source_key,
suppression='', # We can't tie bugs to differences.
first_config_label=first_config_label,
second_config_label=second_config_label,
« no previous file with comments | « no previous file | tools/foozzie/v8_suppressions.py » ('j') | tools/foozzie/v8_suppressions.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698