components/crash_strings.grdp - Issue 2632613003: Improve crash format text for the captured & uploaded case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash_strings.grdp

Issue 2632613003: Improve crash format text for the captured & uploaded case. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/crash_strings.grdp

diff --git a/components/crash_strings.grdp b/components/crash_strings.grdp

index 4e1d6c56e011649845445925576b7aaf4ca5f4e3..145b6fe54b924a62d3626095ee3884b2c1c9817e 100644

--- a/components/crash_strings.grdp

+++ b/components/crash_strings.grdp

@@ -13,11 +13,11 @@

Crash ID <ph name="CRASH_LOCAL_ID">$1<ex>123456-789789</ex></ph>

</message>

- <message name="IDS_CRASH_UPLOAD_TIME_FORMAT" desc="Format for crash entry upload time on chrome://crashes">

- Crash reported on <ph name="UPLOAD_TIME">$1<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph>

+ <message name="IDS_CRASH_UPLOAD_TIME_FORMAT" desc="Format for crash report upload time displayed on chrome://crashes">

+ Crash report uploaded on <ph name="UPLOAD_TIME">$1<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph>

</message>

- <message name="IDS_CRASH_CAPTURE_AND_UPLOAD_TIME_FORMAT" desc="Format for crash capture time, and its upload time, on chrome://crashes">

- Crash report captured on <ph name="CRASH_TIME">$1<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph>, reported on <ph name="UPLOAD_TIME">$2<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph>

+ <message name="IDS_CRASH_CAPTURE_AND_UPLOAD_TIME_FORMAT" desc="Format for the time & date at which the crash report was captured, and subsequently uploaded, to display on chrome://crashes">

Robert Sesek 2017/01/13 22:56:00 I bet the errors don't like this unescaped ampersa

Wez 2017/01/14 00:01:31 I think I'd lose that bet; nice catch.

+ Crash report captured on <ph name="CRASH_TIME">$1<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph>, uploaded on <ph name="UPLOAD_TIME">$2<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph>

</message>

Crash report captured on <ph name="CRASH_TIME">$1<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph> was not uploaded

« no previous file with comments | « no previous file | no next file » | no next file with comments »