Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 26326002: Add python 2.7.5 support on Windows. Not enabled by default. (Closed)

Created:
7 years, 2 months ago by M-A Ruel
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, csharp, Vadim Sh.
Visibility:
Public.

Description

Add python 2.7.5 support on Windows. Not enabled by default. - Python2.7.5 will be installed only if DEPOT_TOOLS_PYTHON_275=1, otherwise 2.6 is installed. - Eventually the default will be changed to install python 2.7.5 for new users. - Afterward, python 2.7.5 will be always installed when not detected and 2.6 will be ignored. README.chromium contains the exact instructions how to recreate python275_bin.zip that was committed independently. I tested it on a vanilla Windows XP image and documented how to install the VC90 CRT redistributable in that specific case in README.chromium. R=iannucci@chromium.org BUG=241769, 257696 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227961

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
A bootstrap/win/python275.new.bat View 1 chunk +8 lines, -0 lines 0 comments Download
M bootstrap/win/win_tools.bat View 4 chunks +26 lines, -2 lines 4 comments Download

Messages

Total messages: 8 (0 generated)
Marc-Antoine Ruel (Google)
7 years, 2 months ago (2013-10-07 19:46:32 UTC) #1
iannucci
lgtm https://codereview.chromium.org/26326002/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/26326002/diff/1/bootstrap/win/win_tools.bat#newcode142 bootstrap/win/win_tools.bat:142: cscript //nologo //e:jscript "%~dp0unzip.js" "%~dp0python275_bin.zip" "%WIN_TOOLS_ROOT_DIR%" Is there ...
7 years, 2 months ago (2013-10-07 23:50:59 UTC) #2
M-A Ruel
https://codereview.chromium.org/26326002/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/26326002/diff/1/bootstrap/win/win_tools.bat#newcode142 bootstrap/win/win_tools.bat:142: cscript //nologo //e:jscript "%~dp0unzip.js" "%~dp0python275_bin.zip" "%WIN_TOOLS_ROOT_DIR%" On 2013/10/07 23:50:59, ...
7 years, 2 months ago (2013-10-08 00:55:52 UTC) #3
M-A Ruel
Committed patchset #1 manually as r227961.
7 years, 2 months ago (2013-10-10 17:57:25 UTC) #4
anatoly techtonik
Why 2.7.5 and not 2.7.x?
6 years, 10 months ago (2014-02-05 10:46:14 UTC) #5
anatoly techtonik
6 years, 10 months ago (2014-02-05 10:46:48 UTC) #6
M-A Ruel
On 2014/02/05 10:46:14, anatoly techtonik wrote: > Why 2.7.5 and not 2.7.x? I don't understand ...
6 years, 10 months ago (2014-02-05 18:29:46 UTC) #7
anatoly techtonik
6 years, 10 months ago (2014-02-05 20:19:52 UTC) #8
Message was sent while issue was closed.
On 2014/02/05 18:29:46, M-A Ruel wrote:
> On 2014/02/05 10:46:14, anatoly techtonik wrote:
> > Why 2.7.5 and not 2.7.x?
> 
> I don't understand the question. The code is indeed 2.7.x compatible. But this
> bootstrapping code was specifically installing 2.7.5.

Why hardcode the environment variable to 2.7.5? Is there a problem with 2.7.6 or
any later version - why it is not called just 27 instead of 275?

Powered by Google App Engine
This is Rietveld 408576698