Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: cc/output/begin_frame_args.cc

Issue 2632563003: [cc] Calculate the correct latest_confirmed_sequence_number in cc::Scheduler. (Closed)
Patch Set: Fix handling of source_id changes and add some Scheduler tests. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cc/scheduler/scheduler.h » ('j') | cc/scheduler/scheduler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/begin_frame_args.h" 5 #include "cc/output/begin_frame_args.h"
6 6
7 #include "base/trace_event/trace_event_argument.h" 7 #include "base/trace_event/trace_event_argument.h"
8 #include "cc/proto/base_conversions.h" 8 #include "cc/proto/base_conversions.h"
9 9
10 namespace cc { 10 namespace cc {
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 base::TimeTicks deadline, 42 base::TimeTicks deadline,
43 base::TimeDelta interval, 43 base::TimeDelta interval,
44 BeginFrameArgs::BeginFrameArgsType type) 44 BeginFrameArgs::BeginFrameArgsType type)
45 : frame_time(frame_time), 45 : frame_time(frame_time),
46 deadline(deadline), 46 deadline(deadline),
47 interval(interval), 47 interval(interval),
48 sequence_number(sequence_number), 48 sequence_number(sequence_number),
49 source_id(source_id), 49 source_id(source_id),
50 type(type), 50 type(type),
51 on_critical_path(true) { 51 on_critical_path(true) {
52 DCHECK_LT(kInvalidFrameNumber, sequence_number); 52 DCHECK_LE(kStartingFrameNumber, sequence_number);
53 } 53 }
54 54
55 BeginFrameArgs BeginFrameArgs::Create(BeginFrameArgs::CreationLocation location, 55 BeginFrameArgs BeginFrameArgs::Create(BeginFrameArgs::CreationLocation location,
56 uint32_t source_id, 56 uint32_t source_id,
57 uint64_t sequence_number, 57 uint64_t sequence_number,
58 base::TimeTicks frame_time, 58 base::TimeTicks frame_time,
59 base::TimeTicks deadline, 59 base::TimeTicks deadline,
60 base::TimeDelta interval, 60 base::TimeDelta interval,
61 BeginFrameArgs::BeginFrameArgsType type) { 61 BeginFrameArgs::BeginFrameArgsType type) {
62 DCHECK_NE(type, BeginFrameArgs::INVALID); 62 DCHECK_NE(type, BeginFrameArgs::INVALID);
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 bool has_damage) 122 bool has_damage)
123 : sequence_number(sequence_number), 123 : sequence_number(sequence_number),
124 latest_confirmed_sequence_number(latest_confirmed_sequence_number), 124 latest_confirmed_sequence_number(latest_confirmed_sequence_number),
125 source_id(source_id), 125 source_id(source_id),
126 remaining_frames(remaining_frames), 126 remaining_frames(remaining_frames),
127 has_damage(has_damage) { 127 has_damage(has_damage) {
128 DCHECK_LT(BeginFrameArgs::kInvalidFrameNumber, sequence_number); 128 DCHECK_LT(BeginFrameArgs::kInvalidFrameNumber, sequence_number);
129 } 129 }
130 130
131 } // namespace cc 131 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | cc/scheduler/scheduler.h » ('j') | cc/scheduler/scheduler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698