Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: ui/aura/client/aura_constants.cc

Issue 2632543003: Refactor and push window properties up to class properties. (Closed)
Patch Set: Caught a few stragglers Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/aura/client/aura_constants.h" 5 #include "ui/aura/client/aura_constants.h"
6 6
7 #include "services/ui/public/interfaces/window_manager_constants.mojom.h" 7 #include "services/ui/public/interfaces/window_manager_constants.mojom.h"
8 #include "ui/aura/window_property.h" 8 #include "ui/base/class_property.h"
9 #include "ui/gfx/geometry/rect.h" 9 #include "ui/gfx/geometry/rect.h"
10 10
11 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, bool) 11 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, bool)
12 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, base::string16*) 12 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, base::string16*)
13 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, ui::ModalType) 13 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, ui::ModalType)
14 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, gfx::ImageSkia*) 14 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, gfx::ImageSkia*)
15 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, gfx::Rect*) 15 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, gfx::Rect*)
16 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, gfx::Size*) 16 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, gfx::Size*)
17 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, std::string*) 17 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, std::string*)
18 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, ui::WindowShowState) 18 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, ui::WindowShowState)
19 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, ui::mojom::WindowType); 19 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, ui::mojom::WindowType);
20 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, void*) 20 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, void*)
21 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, SkColor) 21 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, SkColor)
22 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, int32_t) 22 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, int32_t)
23 DECLARE_EXPORTED_WINDOW_PROPERTY_TYPE(AURA_EXPORT, int64_t) 23 DECLARE_EXPORTED_UI_CLASS_PROPERTY_TYPE(AURA_EXPORT, int64_t)
24 24
25 namespace aura { 25 namespace aura {
26 namespace client { 26 namespace client {
27 27
28 // Alphabetical sort. 28 // Alphabetical sort.
29 29
30 DEFINE_WINDOW_PROPERTY_KEY(bool, kAccessibilityFocusFallsbackToWidgetKey, true); 30 DEFINE_UI_CLASS_PROPERTY_KEY(
31 DEFINE_WINDOW_PROPERTY_KEY(bool, kAlwaysOnTopKey, false); 31 bool, kAccessibilityFocusFallsbackToWidgetKey, true);
32 DEFINE_WINDOW_PROPERTY_KEY(bool, kAnimationsDisabledKey, false); 32 DEFINE_UI_CLASS_PROPERTY_KEY(bool, kAlwaysOnTopKey, false);
33 DEFINE_OWNED_WINDOW_PROPERTY_KEY(gfx::ImageSkia, kAppIconKey, nullptr); 33 DEFINE_UI_CLASS_PROPERTY_KEY(bool, kAnimationsDisabledKey, false);
34 DEFINE_OWNED_WINDOW_PROPERTY_KEY(std::string, kAppIdKey, nullptr); 34 DEFINE_OWNED_UI_CLASS_PROPERTY_KEY(gfx::ImageSkia, kAppIconKey, nullptr);
35 DEFINE_WINDOW_PROPERTY_KEY(int, kAppType, 0); 35 DEFINE_OWNED_UI_CLASS_PROPERTY_KEY(std::string, kAppIdKey, nullptr);
36 DEFINE_WINDOW_PROPERTY_KEY(bool, kConstrainedWindowKey, false); 36 DEFINE_UI_CLASS_PROPERTY_KEY(int, kAppType, 0);
37 DEFINE_WINDOW_PROPERTY_KEY(bool, kDrawAttentionKey, false); 37 DEFINE_UI_CLASS_PROPERTY_KEY(bool, kConstrainedWindowKey, false);
38 DEFINE_WINDOW_PROPERTY_KEY(bool, kMirroringEnabledKey, false); 38 DEFINE_UI_CLASS_PROPERTY_KEY(bool, kDrawAttentionKey, false);
39 DEFINE_WINDOW_PROPERTY_KEY(Window*, kHostWindowKey, nullptr); 39 DEFINE_UI_CLASS_PROPERTY_KEY(bool, kMirroringEnabledKey, false);
40 DEFINE_WINDOW_PROPERTY_KEY(ui::ModalType, kModalKey, ui::MODAL_TYPE_NONE); 40 DEFINE_UI_CLASS_PROPERTY_KEY(Window*, kHostWindowKey, nullptr);
41 DEFINE_OWNED_WINDOW_PROPERTY_KEY(std::string, kNameKey, nullptr); 41 DEFINE_UI_CLASS_PROPERTY_KEY(ui::ModalType, kModalKey, ui::MODAL_TYPE_NONE);
42 DEFINE_OWNED_WINDOW_PROPERTY_KEY(gfx::Size, kPreferredSize, nullptr); 42 DEFINE_OWNED_UI_CLASS_PROPERTY_KEY(std::string, kNameKey, nullptr);
43 DEFINE_WINDOW_PROPERTY_KEY(int32_t, 43 DEFINE_OWNED_UI_CLASS_PROPERTY_KEY(gfx::Size, kPreferredSize, nullptr);
44 kResizeBehaviorKey, 44 DEFINE_UI_CLASS_PROPERTY_KEY(int32_t,
45 ui::mojom::kResizeBehaviorCanResize); 45 kResizeBehaviorKey,
46 DEFINE_OWNED_WINDOW_PROPERTY_KEY(gfx::Rect, kRestoreBoundsKey, nullptr); 46 ui::mojom::kResizeBehaviorCanResize);
47 DEFINE_WINDOW_PROPERTY_KEY( 47 DEFINE_OWNED_UI_CLASS_PROPERTY_KEY(gfx::Rect, kRestoreBoundsKey, nullptr);
48 DEFINE_UI_CLASS_PROPERTY_KEY(
48 ui::WindowShowState, kPreMinimizedShowStateKey, ui::SHOW_STATE_DEFAULT); 49 ui::WindowShowState, kPreMinimizedShowStateKey, ui::SHOW_STATE_DEFAULT);
49 DEFINE_WINDOW_PROPERTY_KEY( 50 DEFINE_UI_CLASS_PROPERTY_KEY(
50 ui::WindowShowState, kPreFullscreenShowStateKey, ui::SHOW_STATE_DEFAULT); 51 ui::WindowShowState, kPreFullscreenShowStateKey, ui::SHOW_STATE_DEFAULT);
51 DEFINE_WINDOW_PROPERTY_KEY( 52 DEFINE_UI_CLASS_PROPERTY_KEY(
52 ui::WindowShowState, kShowStateKey, ui::SHOW_STATE_DEFAULT); 53 ui::WindowShowState, kShowStateKey, ui::SHOW_STATE_DEFAULT);
53 DEFINE_OWNED_WINDOW_PROPERTY_KEY(base::string16, kTitleKey, nullptr); 54 DEFINE_OWNED_UI_CLASS_PROPERTY_KEY(base::string16, kTitleKey, nullptr);
54 DEFINE_WINDOW_PROPERTY_KEY(int, kTopViewInset, 0); 55 DEFINE_UI_CLASS_PROPERTY_KEY(int, kTopViewInset, 0);
55 DEFINE_WINDOW_PROPERTY_KEY(SkColor, kTopViewColor, SK_ColorTRANSPARENT); 56 DEFINE_UI_CLASS_PROPERTY_KEY(SkColor, kTopViewColor, SK_ColorTRANSPARENT);
56 DEFINE_OWNED_WINDOW_PROPERTY_KEY(gfx::ImageSkia, kWindowIconKey, nullptr); 57 DEFINE_OWNED_UI_CLASS_PROPERTY_KEY(gfx::ImageSkia, kWindowIconKey, nullptr);
57 DEFINE_WINDOW_PROPERTY_KEY(ui::mojom::WindowType, 58 DEFINE_UI_CLASS_PROPERTY_KEY(ui::mojom::WindowType,
58 kWindowTypeKey, 59 kWindowTypeKey,
59 ui::mojom::WindowType::UNKNOWN); 60 ui::mojom::WindowType::UNKNOWN);
60 61
61 } // namespace client 62 } // namespace client
62 } // namespace aura 63 } // namespace aura
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698