Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Side by Side Diff: ui/wm/public/tooltip_client.cc

Issue 2632543003: Refactor and push window properties up to class properties. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/wm/public/tooltip_client.h" 5 #include "ui/wm/public/tooltip_client.h"
6 6
7 #include "ui/aura/window.h" 7 #include "ui/aura/window.h"
8 #include "ui/aura/window_property.h" 8 #include "ui/base/class_property.h"
9 9
10 DECLARE_WINDOW_PROPERTY_TYPE(aura::client::TooltipClient*) 10 DECLARE_CLASS_PROPERTY_TYPE(aura::client::TooltipClient*)
11 DECLARE_WINDOW_PROPERTY_TYPE(void**) 11 DECLARE_CLASS_PROPERTY_TYPE(void**)
12 12
13 namespace aura { 13 namespace aura {
14 namespace client { 14 namespace client {
15 15
16 DEFINE_LOCAL_WINDOW_PROPERTY_KEY( 16 DEFINE_LOCAL_CLASS_PROPERTY_KEY(
17 TooltipClient*, kRootWindowTooltipClientKey, NULL); 17 TooltipClient*, kRootWindowTooltipClientKey, NULL);
18 DEFINE_LOCAL_WINDOW_PROPERTY_KEY(base::string16*, kTooltipTextKey, NULL); 18 DEFINE_LOCAL_CLASS_PROPERTY_KEY(base::string16*, kTooltipTextKey, NULL);
19 DEFINE_LOCAL_WINDOW_PROPERTY_KEY(void*, kTooltipIdKey, NULL); 19 DEFINE_LOCAL_CLASS_PROPERTY_KEY(void*, kTooltipIdKey, NULL);
20 20
21 void SetTooltipClient(Window* root_window, TooltipClient* client) { 21 void SetTooltipClient(Window* root_window, TooltipClient* client) {
22 DCHECK_EQ(root_window->GetRootWindow(), root_window); 22 DCHECK_EQ(root_window->GetRootWindow(), root_window);
23 root_window->SetProperty(kRootWindowTooltipClientKey, client); 23 root_window->SetProperty(kRootWindowTooltipClientKey, client);
24 } 24 }
25 25
26 TooltipClient* GetTooltipClient(Window* root_window) { 26 TooltipClient* GetTooltipClient(Window* root_window) {
27 if (root_window) 27 if (root_window)
28 DCHECK_EQ(root_window->GetRootWindow(), root_window); 28 DCHECK_EQ(root_window->GetRootWindow(), root_window);
29 return root_window ? 29 return root_window ?
(...skipping 12 matching lines...) Expand all
42 base::string16* string_ptr = window->GetProperty(kTooltipTextKey); 42 base::string16* string_ptr = window->GetProperty(kTooltipTextKey);
43 return string_ptr ? *string_ptr : base::string16(); 43 return string_ptr ? *string_ptr : base::string16();
44 } 44 }
45 45
46 const void* GetTooltipId(Window* window) { 46 const void* GetTooltipId(Window* window) {
47 return window->GetProperty(kTooltipIdKey); 47 return window->GetProperty(kTooltipIdKey);
48 } 48 }
49 49
50 } // namespace client 50 } // namespace client
51 } // namespace aura 51 } // namespace aura
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698