Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: ash/aura/aura_layout_manager_adapter.cc

Issue 2632543003: Refactor and push window properties up to class properties. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/common/wm_window.cc » ('j') | ui/aura/window.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/aura/aura_layout_manager_adapter.h" 5 #include "ash/aura/aura_layout_manager_adapter.h"
6 6
7 #include "ash/common/wm_layout_manager.h" 7 #include "ash/common/wm_layout_manager.h"
8 #include "ash/common/wm_window.h" 8 #include "ash/common/wm_window.h"
9 #include "ui/aura/window_property.h" 9 #include "ui/base/class_property.h"
10 10
11 DECLARE_WINDOW_PROPERTY_TYPE(ash::AuraLayoutManagerAdapter*); 11 DECLARE_CLASS_PROPERTY_TYPE(ash::AuraLayoutManagerAdapter*);
12 12
13 namespace ash { 13 namespace ash {
14 namespace { 14 namespace {
15 // AuraLayoutManagerAdapter is an aura::LayoutManager, so it's owned by the 15 // AuraLayoutManagerAdapter is an aura::LayoutManager, so it's owned by the
16 // aura::Window it is installed on. This property is used to lookup the 16 // aura::Window it is installed on. This property is used to lookup the
17 // AuraLayoutManagerAdapter given only an aura::Window. 17 // AuraLayoutManagerAdapter given only an aura::Window.
18 DEFINE_WINDOW_PROPERTY_KEY(AuraLayoutManagerAdapter*, 18 DEFINE_CLASS_PROPERTY_KEY(AuraLayoutManagerAdapter*,
19 kAuraLayoutManagerAdapter, 19 kAuraLayoutManagerAdapter,
20 nullptr); 20 nullptr);
21 } // namespace 21 } // namespace
22 22
23 AuraLayoutManagerAdapter::AuraLayoutManagerAdapter( 23 AuraLayoutManagerAdapter::AuraLayoutManagerAdapter(
24 aura::Window* window, 24 aura::Window* window,
25 std::unique_ptr<WmLayoutManager> wm_layout_manager) 25 std::unique_ptr<WmLayoutManager> wm_layout_manager)
26 : window_(window), wm_layout_manager_(std::move(wm_layout_manager)) { 26 : window_(window), wm_layout_manager_(std::move(wm_layout_manager)) {
27 window->SetProperty(kAuraLayoutManagerAdapter, this); 27 window->SetProperty(kAuraLayoutManagerAdapter, this);
28 } 28 }
29 29
30 AuraLayoutManagerAdapter::~AuraLayoutManagerAdapter() { 30 AuraLayoutManagerAdapter::~AuraLayoutManagerAdapter() {
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 visible); 63 visible);
64 } 64 }
65 65
66 void AuraLayoutManagerAdapter::SetChildBounds( 66 void AuraLayoutManagerAdapter::SetChildBounds(
67 aura::Window* child, 67 aura::Window* child,
68 const gfx::Rect& requested_bounds) { 68 const gfx::Rect& requested_bounds) {
69 wm_layout_manager_->SetChildBounds(WmWindow::Get(child), requested_bounds); 69 wm_layout_manager_->SetChildBounds(WmWindow::Get(child), requested_bounds);
70 } 70 }
71 71
72 } // namespace ash 72 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | ash/common/wm_window.cc » ('j') | ui/aura/window.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698